zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TcpPort doesn't connect when calling gmail with non-proxied UDP disabled.

Browse Source 
The same check has been made into turnport.cc but missed this place.

BUG=webrtc:5030
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1367553002 .

Cr-Commit-Position: refs/heads/master@{#10038}
This commit is contained in:
Guo-wei Shieh
2015-09-23 13:57:07 -07:00
parent cdfe20bfc1
commit 2e4b620471
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/p2p/base/tcpport.cc
View File

@ -379,6 +379,15 @@ void TCPConnection::OnConnect(rtc::AsyncPacketSocket* socket) {
<< socket->GetRemoteAddress().ToSensitiveString(); << socket->GetRemoteAddress().ToSensitiveString();
set_connected(true); set_connected(true);
connection_pending_ = false; connection_pending_ = false;
} else if (IPIsAny(port()->ip())) {
LOG(LS_WARNING) << "Socket is bound to a different address:"
<< socket->GetLocalAddress().ipaddr().ToString()
<< ", rather then the local port:"
<< port()->ip().ToString()
<< ". Still allowing it since it's any address"
<< ", possibly caused by multi-routes being disabled.";
set_connected(true);
connection_pending_ = false;
} else { } else {
LOG_J(LS_WARNING, this) << "Dropping connection as TCP socket bound to IP " LOG_J(LS_WARNING, this) << "Dropping connection as TCP socket bound to IP "
<< socket_ip.ToSensitiveString() << socket_ip.ToSensitiveString()