zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log error on ssltcp failures (fake ssl handshake)

Browse Source 
Followup to https://webrtc-review.googlesource.com/c/src/+/229384.

Bug: None
Change-Id: I9d0a4f29514b5699f90e9a8af1457a7b68de3bd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229586
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34833}
This commit is contained in:
Niels Möller
2021-08-23 11:17:56 +02:00
committed by WebRTC LUCI CQ
parent 8fa5e65818
commit 2eb465fc7b
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rtc_base/socket_adapters.cc
View File

@ -183,6 +183,7 @@ void AsyncSSLSocket::OnConnectEvent(Socket* socket) {
// TODO: we could buffer output too... // TODO: we could buffer output too...
const int res = DirectSend(kSslClientHello, sizeof(kSslClientHello)); const int res = DirectSend(kSslClientHello, sizeof(kSslClientHello));
if (res != sizeof(kSslClientHello)) { if (res != sizeof(kSslClientHello)) {
RTC_LOG(LS_ERROR) << "Sending fake SSL ClientHello message failed.";
Close(); Close();
SignalCloseEvent(this, 0); SignalCloseEvent(this, 0);
} }
@ -193,6 +194,7 @@ void AsyncSSLSocket::ProcessInput(char* data, size_t* len) {
return; return;
if (memcmp(kSslServerHello, data, sizeof(kSslServerHello)) != 0) { if (memcmp(kSslServerHello, data, sizeof(kSslServerHello)) != 0) {
RTC_LOG(LS_ERROR) << "Received non-matching fake SSL ServerHello message.";
Close(); Close();
SignalCloseEvent(this, 0); // TODO: error code? SignalCloseEvent(this, 0); // TODO: error code?
return; return;