zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add RTP sequence number to TransportFeedbackObserver::AddPacket()

Browse Source 
With this change, both the normal RTP and the transport-wide sequence
numbers are propagated with with AddPacket() call via a new
RtpPacketSendInfo struct, replacing the previous set of parameters.

The intent with this is that SendTimeHistory can hold a mapping from
transport-wide to rtp sequence numbers, and then via callbacks let the
RTP modules know when packets have been received by the remote end.

Bug: webrtc:8975
Change-Id: I6a24fc6282cbb041393752d39593c2867b242192
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133021
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27708}
This commit is contained in:
Erik Språng
2019-04-23 12:00:11 +02:00
committed by Commit Bot
parent d0e0ed82af
commit 30a276b5d7
17 changed files with 166 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/congestion_controller/include/send_side_congestion_controller.h
View File

@ -43,7 +43,7 @@ class RateLimiter;
class RtcEventLog;
class CongestionWindowPushbackController;
// Deprecated, for somewhat similar funtionality GoogCcNetworkController can be
// Deprecated, for somewhat similar functionality GoogCcNetworkController can be
// used via GoogCcNetworkControllerFactory.
class DEPRECATED_SendSideCongestionController
: public SendSideCongestionControllerInterface {
@ -107,10 +107,7 @@ class DEPRECATED_SendSideCongestionController
void Process() override;
// Implements TransportFeedbackObserver.
void AddPacket(uint32_t ssrc,
uint16_t sequence_number,
size_t length,
const PacedPacketInfo& pacing_info) override;
void OnAddPacket(const RtpPacketSendInfo& packet_info) override;
void OnTransportFeedback(const rtcp::TransportFeedback& feedback) override;
std::vector<PacketFeedback> GetTransportFeedbackVector() const;