zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify NACL dependency from peerconnection API.

Browse Source 
Also gets rid of refs to bug 7504, which is now closed.

Bug: webrtc:7504
Change-Id: I105355a5372ad9c2ae8ef52ae275cb4037731c3d
Reviewed-on: https://webrtc-review.googlesource.com/34643
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21366}
This commit is contained in:
Patrik Höglund
2017-12-19 11:45:31 +01:00
committed by Commit Bot
parent 2f3f722aa8
commit 30bd03b81d
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
api/BUILD.gn
View File

@ -90,7 +90,6 @@ rtc_static_library("libjingle_peerconnection_api") {
":optional",
":rtc_stats_api",
":video_frame_api",
"../rtc_base:checks",
"audio_codecs:audio_codecs_api",
# Basically, don't add stuff here. You might break sensitive downstream
@ -105,11 +104,8 @@ rtc_static_library("libjingle_peerconnection_api") {
"../rtc_base:rtc_base_approved",
"../rtc_base:stringutils",
]
# This is needed until bugs.webrtc.org/7504 is removed so this target can
# properly depend on ../media:rtc_media_base
# TODO(kjellander): Remove this dependency.
if (is_nacl) {
# This is needed by .h files included from rtc_base.
deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
}
}
@ -119,7 +115,7 @@ rtc_source_set("peerconnection_and_implicit_call_api") {
# and the entire call module with it. We need to either get rid of this
# dependency or pull most of call/ into the API. For now, silence the warnings
# this creates since it creates a circular dependency (call very much depends
# on API). See bugs.webrtc.org/7504.
# on API). See bugs.webrtc.org/8667.
check_includes = false
sources = [
"peerconnectioninterface.h",