zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comment for RtpVideoStreamReceiver2::RequestPacketRetransmit.

Browse Source 
Bug: none
Change-Id: I8a9d13e23e403eac3d31a30fa77336568141c763
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220841
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34209}
This commit is contained in:
Tommi
2021-06-01 09:50:26 +02:00
committed by WebRTC LUCI CQ
parent e93dc74483
commit 31b564959c
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
video/rtp_video_stream_receiver2.cc
View File

@ -719,6 +719,7 @@ bool RtpVideoStreamReceiver2::IsDecryptable() const {
// RTC_RUN_ON(packet_sequence_checker_) // RTC_RUN_ON(packet_sequence_checker_)
void RtpVideoStreamReceiver2::OnInsertedPacket( void RtpVideoStreamReceiver2::OnInsertedPacket(
video_coding::PacketBuffer::InsertResult result) { video_coding::PacketBuffer::InsertResult result) {
RTC_DCHECK_RUN_ON(&worker_task_checker_);
video_coding::PacketBuffer::Packet* first_packet = nullptr; video_coding::PacketBuffer::Packet* first_packet = nullptr;
int max_nack_count; int max_nack_count;
int64_t min_recv_time; int64_t min_recv_time;
@ -942,6 +943,7 @@ void RtpVideoStreamReceiver2::ManageFrame(
// RTC_RUN_ON(packet_sequence_checker_) // RTC_RUN_ON(packet_sequence_checker_)
void RtpVideoStreamReceiver2::ReceivePacket(const RtpPacketReceived& packet) { void RtpVideoStreamReceiver2::ReceivePacket(const RtpPacketReceived& packet) {
RTC_DCHECK_RUN_ON(&worker_task_checker_);
if (packet.payload_size() == 0) { if (packet.payload_size() == 0) {
// Padding or keep-alive packet. // Padding or keep-alive packet.
// TODO(nisse): Could drop empty packets earlier, but need to figure out how // TODO(nisse): Could drop empty packets earlier, but need to figure out how
@ -992,6 +994,8 @@ void RtpVideoStreamReceiver2::ParseAndHandleEncapsulatingHeader(
// correctly calculate frame references. // correctly calculate frame references.
// RTC_RUN_ON(packet_sequence_checker_) // RTC_RUN_ON(packet_sequence_checker_)
void RtpVideoStreamReceiver2::NotifyReceiverOfEmptyPacket(uint16_t seq_num) { void RtpVideoStreamReceiver2::NotifyReceiverOfEmptyPacket(uint16_t seq_num) {
RTC_DCHECK_RUN_ON(&worker_task_checker_);
OnCompleteFrames(reference_finder_->PaddingReceived(seq_num)); OnCompleteFrames(reference_finder_->PaddingReceived(seq_num));
OnInsertedPacket(packet_buffer_.InsertPadding(seq_num)); OnInsertedPacket(packet_buffer_.InsertPadding(seq_num));
@ -1126,6 +1130,8 @@ void RtpVideoStreamReceiver2::UpdateHistograms() {
// RTC_RUN_ON(packet_sequence_checker_) // RTC_RUN_ON(packet_sequence_checker_)
void RtpVideoStreamReceiver2::InsertSpsPpsIntoTracker(uint8_t payload_type) { void RtpVideoStreamReceiver2::InsertSpsPpsIntoTracker(uint8_t payload_type) {
RTC_DCHECK_RUN_ON(&worker_task_checker_);
auto codec_params_it = pt_codec_params_.find(payload_type); auto codec_params_it = pt_codec_params_.find(payload_type);
if (codec_params_it == pt_codec_params_.end()) if (codec_params_it == pt_codec_params_.end())
return; return;

5
video/rtp_video_stream_receiver2.h
View File

@ -153,7 +153,10 @@ class RtpVideoStreamReceiver2 : public LossNotificationSender,
// Decryption not SRTP. // Decryption not SRTP.
bool IsDecryptable() const; bool IsDecryptable() const;
// Don't use, still experimental. // Request packet retransmits via NACK. Called via
// VideoReceiveStream2::SendNack, which gets called when
// RtpVideoStreamReceiver2::RtcpFeedbackBuffer's SendNack and
// SendBufferedRtcpFeedback methods (see `rtcp_feedback_buffer_` below).
void RequestPacketRetransmit(const std::vector<uint16_t>& sequence_numbers); void RequestPacketRetransmit(const std::vector<uint16_t>& sequence_numbers);
// Implements OnDecryptedFrameCallback. // Implements OnDecryptedFrameCallback.