diff --git a/api/peerconnectioninterface.h b/api/peerconnectioninterface.h index e82fa7559d..60f16356c1 100644 --- a/api/peerconnectioninterface.h +++ b/api/peerconnectioninterface.h @@ -1105,11 +1105,6 @@ rtc::scoped_refptr CreatePeerConnectionFactory( rtc::scoped_refptr audio_encoder_factory, rtc::scoped_refptr audio_decoder_factory); -// Deprecated variant of the above. -// TODO(kwiberg): Remove. -rtc::scoped_refptr -CreatePeerConnectionFactory(); - // Create a new instance of PeerConnectionFactoryInterface. // // |network_thread|, |worker_thread| and |signaling_thread| are @@ -1130,16 +1125,6 @@ rtc::scoped_refptr CreatePeerConnectionFactory( cricket::WebRtcVideoEncoderFactory* video_encoder_factory, cricket::WebRtcVideoDecoderFactory* video_decoder_factory); -// Deprecated variant of the above. -// TODO(kwiberg): Remove. -rtc::scoped_refptr CreatePeerConnectionFactory( - rtc::Thread* network_thread, - rtc::Thread* worker_thread, - rtc::Thread* signaling_thread, - AudioDeviceModule* default_adm, - cricket::WebRtcVideoEncoderFactory* encoder_factory, - cricket::WebRtcVideoDecoderFactory* decoder_factory); - // Create a new instance of PeerConnectionFactoryInterface with optional // external audio mixed and audio processing modules. // @@ -1189,18 +1174,6 @@ CreatePeerConnectionFactoryWithAudioMixer( cricket::WebRtcVideoDecoderFactory* video_decoder_factory, rtc::scoped_refptr audio_mixer); -// Deprecated variant of the above. -// TODO(kwiberg): Remove. -rtc::scoped_refptr -CreatePeerConnectionFactoryWithAudioMixer( - rtc::Thread* network_thread, - rtc::Thread* worker_thread, - rtc::Thread* signaling_thread, - AudioDeviceModule* default_adm, - cricket::WebRtcVideoEncoderFactory* encoder_factory, - cricket::WebRtcVideoDecoderFactory* decoder_factory, - rtc::scoped_refptr audio_mixer); - // Create a new instance of PeerConnectionFactoryInterface. // Same thread is used as worker and network thread. inline rtc::scoped_refptr @@ -1218,20 +1191,6 @@ CreatePeerConnectionFactory( video_encoder_factory, video_decoder_factory); } -// Deprecated variant of the above. -// TODO(kwiberg): Remove. -inline rtc::scoped_refptr -CreatePeerConnectionFactory( - rtc::Thread* worker_and_network_thread, - rtc::Thread* signaling_thread, - AudioDeviceModule* default_adm, - cricket::WebRtcVideoEncoderFactory* encoder_factory, - cricket::WebRtcVideoDecoderFactory* decoder_factory) { - return CreatePeerConnectionFactory( - worker_and_network_thread, worker_and_network_thread, signaling_thread, - default_adm, encoder_factory, decoder_factory); -} - // This is a lower-level version of the CreatePeerConnectionFactory functions // above. It's implemented in the "peerconnection" build target, whereas the // above methods are only implemented in the broader "libjingle_peerconnection" diff --git a/pc/BUILD.gn b/pc/BUILD.gn index 116c1acec1..450e6e0d35 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -205,8 +205,6 @@ rtc_static_library("create_pc_factory") { "../api:audio_mixer_api", "../api:libjingle_peerconnection_api", "../api/audio_codecs:audio_codecs_api", - "../api/audio_codecs:builtin_audio_decoder_factory", - "../api/audio_codecs:builtin_audio_encoder_factory", "../api/video_codecs:video_codecs_api", "../call", "../call:call_interfaces", diff --git a/pc/createpeerconnectionfactory.cc b/pc/createpeerconnectionfactory.cc index 79af61e88b..8098ecf1fd 100644 --- a/pc/createpeerconnectionfactory.cc +++ b/pc/createpeerconnectionfactory.cc @@ -8,8 +8,6 @@ * be found in the AUTHORS file in the root of the source tree. */ -#include "api/audio_codecs/builtin_audio_decoder_factory.h" -#include "api/audio_codecs/builtin_audio_encoder_factory.h" #include "api/peerconnectioninterface.h" #include "api/video_codecs/video_decoder_factory.h" #include "api/video_codecs/video_encoder_factory.h" @@ -35,12 +33,6 @@ rtc::scoped_refptr CreatePeerConnectionFactory( nullptr /*audio_mixer*/); } -rtc::scoped_refptr -CreatePeerConnectionFactory() { - return CreatePeerConnectionFactory(CreateBuiltinAudioEncoderFactory(), - CreateBuiltinAudioDecoderFactory()); -} - // Note: all the other CreatePeerConnectionFactory variants just end up calling // this, ultimately. rtc::scoped_refptr CreatePeerConnectionFactory( @@ -122,33 +114,6 @@ CreatePeerConnectionFactoryWithAudioMixer( video_decoder_factory, audio_mixer, nullptr); } -rtc::scoped_refptr -CreatePeerConnectionFactoryWithAudioMixer( - rtc::Thread* network_thread, - rtc::Thread* worker_thread, - rtc::Thread* signaling_thread, - AudioDeviceModule* default_adm, - cricket::WebRtcVideoEncoderFactory* encoder_factory, - cricket::WebRtcVideoDecoderFactory* decoder_factory, - rtc::scoped_refptr audio_mixer) { - return CreatePeerConnectionFactoryWithAudioMixer( - network_thread, worker_thread, signaling_thread, default_adm, - CreateBuiltinAudioEncoderFactory(), CreateBuiltinAudioDecoderFactory(), - encoder_factory, decoder_factory, audio_mixer); -} - -rtc::scoped_refptr CreatePeerConnectionFactory( - rtc::Thread* network_thread, - rtc::Thread* worker_thread, - rtc::Thread* signaling_thread, - AudioDeviceModule* default_adm, - cricket::WebRtcVideoEncoderFactory* encoder_factory, - cricket::WebRtcVideoDecoderFactory* decoder_factory) { - return CreatePeerConnectionFactoryWithAudioMixer( - network_thread, worker_thread, signaling_thread, default_adm, - encoder_factory, decoder_factory, nullptr); -} - rtc::scoped_refptr CreatePeerConnectionFactory( rtc::Thread* network_thread, rtc::Thread* worker_thread, diff --git a/pc/peerconnection_bundle_unittest.cc b/pc/peerconnection_bundle_unittest.cc index 1ade191184..d36ad2e3c2 100644 --- a/pc/peerconnection_bundle_unittest.cc +++ b/pc/peerconnection_bundle_unittest.cc @@ -8,6 +8,8 @@ * be found in the AUTHORS file in the root of the source tree. */ +#include "api/audio_codecs/builtin_audio_decoder_factory.h" +#include "api/audio_codecs/builtin_audio_encoder_factory.h" #include "api/peerconnectionproxy.h" #include "p2p/base/fakeportallocator.h" #include "p2p/base/teststunserver.h" @@ -145,7 +147,8 @@ class PeerConnectionBundleTest : public ::testing::Test { #endif pc_factory_ = CreatePeerConnectionFactory( rtc::Thread::Current(), rtc::Thread::Current(), rtc::Thread::Current(), - FakeAudioCaptureModule::Create(), nullptr, nullptr); + FakeAudioCaptureModule::Create(), CreateBuiltinAudioEncoderFactory(), + CreateBuiltinAudioDecoderFactory(), nullptr, nullptr); } WrapperPtr CreatePeerConnection() {