zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

APM pre-gain sub-module: code improvements.

Browse Source 
- No need to have a unique ptr for the swap queue
- Remove default case from the switch in
  AudioProcessingImpl::HandleRuntimeSettings()

Bug: webrtc:9138
Change-Id: I346ba1db6510b5caa637510298b67ead07197b81
Reviewed-on: https://webrtc-review.googlesource.com/71164
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22958}
This commit is contained in:
Alessio Bazzica
2018-04-20 13:16:55 +02:00
committed by Commit Bot
parent a16ac58a5e
commit 33444dc835
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/audio_processing/audio_processing_impl.h
View File

@ -149,7 +149,7 @@ class AudioProcessingImpl : public AudioProcessing {
std::unique_ptr<ApmDataDumper> data_dumper_;
static int instance_count_;
std::unique_ptr<SwapQueue<RuntimeSetting>> runtime_settings_;
SwapQueue<RuntimeSetting> runtime_settings_;
// Class providing thread-safe message pipe functionality for
// |runtime_settings_|.
@ -161,7 +161,7 @@ class AudioProcessingImpl : public AudioProcessing {
void Enqueue(RuntimeSetting setting);
private:
SwapQueue<RuntimeSetting>* runtime_settings_;
SwapQueue<RuntimeSetting>& runtime_settings_;
} runtime_settings_enqueuer_;
// Submodule interface implementations.