zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix video_replay to build and actually work

Browse Source 
Add it to default build target, so it won't get broken accidentally
again. Fix configuration issue with field trials (new parameter was
added recently, but wasn't set by video_replay)

Bug: webrtc:11287
Change-Id: I9c18746d899acd7ac68c1b9b3a646b862c41897a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166900
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30345}
This commit is contained in:
Ilya Nikolaevskiy
2020-01-21 13:38:19 +01:00
committed by Commit Bot
parent 5bb9adcb08
commit 33aaa35d54
3 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
BUILD.gn
View File

@ -62,6 +62,7 @@ if (!build_with_chromium) {
"video:screenshare_loopback",
"video:sv_loopback",
"video:video_loopback",
"video:video_replay",
]
if (!is_asan) {
# Do not build :webrtc_lib_link_test because lld complains on some OS

2
video/BUILD.gn
View File

@ -474,7 +474,9 @@ if (rtc_include_tests) {
"../api/rtc_event_log",
"../api/task_queue:default_task_queue_factory",
"../api/test/video:function_video_factory",
"../api/transport:field_trial_based_config",
"../api/video_codecs:video_codecs_api",
"../call",
"../call:call_interfaces",
"../common_video",
"../media:rtc_internal_video_codecs",

2
video/video_replay.cc
View File

@ -19,6 +19,7 @@
#include "api/rtc_event_log/rtc_event_log.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "api/test/video/function_video_decoder_factory.h"
#include "api/transport/field_trial_based_config.h"
#include "api/video_codecs/video_decoder.h"
#include "call/call.h"
#include "common_video/libyuv/include/webrtc_libyuv.h"
@ -267,6 +268,7 @@ class RtpReplayer final {
webrtc::RtcEventLogNull event_log;
Call::Config call_config(&event_log);
call_config.task_queue_factory = task_queue_factory.get();
call_config.trials = new FieldTrialBasedConfig();
std::unique_ptr<Call> call(Call::Create(call_config));
std::unique_ptr<StreamState> stream_state;
// Attempt to load the configuration