zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding NetEq buffer full metric to UMA.

Browse Source 
BUG: webrtc:9882
Change-Id: Idbcbbbd99855b2251fbb66629efeab4f2d1f6498
Reviewed-on: https://webrtc-review.googlesource.com/c/106400
Commit-Queue: Minyue Li <minyue@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25230}
This commit is contained in:
Minyue Li
2018-10-16 16:55:52 +02:00
committed by Commit Bot
parent a240daaae9
commit 34d990fef9
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/audio_coding/neteq/statistics_calculator.cc
View File

@ -126,7 +126,10 @@ StatisticsCalculator::StatisticsCalculator()
100),
excess_buffer_delay_("WebRTC.Audio.AverageExcessBufferDelayMs",
60000, // 60 seconds report interval.
1000) {}
1000),
buffer_full_counter_("WebRTC.Audio.JitterBufferFullPerMinute",
60000, // 60 seconds report interval.
100) {}
StatisticsCalculator::~StatisticsCalculator() = default;
@ -229,6 +232,7 @@ void StatisticsCalculator::IncreaseCounter(size_t num_samples, int fs_hz) {
rtc::CheckedDivExact(static_cast<int>(1000 * num_samples), fs_hz);
delayed_packet_outage_counter_.AdvanceClock(time_step_ms);
excess_buffer_delay_.AdvanceClock(time_step_ms);
buffer_full_counter_.AdvanceClock(time_step_ms);
timestamps_since_last_report_ += static_cast<uint32_t>(num_samples);
if (timestamps_since_last_report_ >
static_cast<uint32_t>(fs_hz * kMaxReportPeriod)) {
@ -250,6 +254,7 @@ void StatisticsCalculator::SecondaryDecodedSamples(int num_samples) {
void StatisticsCalculator::FlushedPacketBuffer() {
operations_and_state_.packet_buffer_flushes++;
buffer_full_counter_.RegisterSample();
}
void StatisticsCalculator::LogDelayedPacketOutageEvent(int outage_duration_ms) {

1
modules/audio_coding/neteq/statistics_calculator.h
View File

@ -199,6 +199,7 @@ class StatisticsCalculator {
size_t discarded_secondary_packets_;
PeriodicUmaCount delayed_packet_outage_counter_;
PeriodicUmaAverage excess_buffer_delay_;
PeriodicUmaCount buffer_full_counter_;
RTC_DISALLOW_COPY_AND_ASSIGN(StatisticsCalculator);
};