zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Chromium clang plugin warnings

Browse Source 
NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2286063005
Cr-Commit-Position: refs/heads/master@{#13955}
This commit is contained in:
kwiberg
2016-08-29 05:33:32 -07:00
committed by Commit bot
parent e4b4695582
commit 36a43887f3
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/modules/audio_coding/BUILD.gn
View File

@ -127,11 +127,6 @@ source_set("audio_coding") {
] ]
} }
if (is_clang) {
# Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
deps = audio_coding_deps + [ deps = audio_coding_deps + [
":neteq", ":neteq",
":rent_a_codec", ":rent_a_codec",

10
webrtc/modules/audio_coding/acm2/audio_coding_module.cc
View File

@ -1268,6 +1268,16 @@ void AudioCodingModuleImpl::GetDecodingCallStatistics(
} // namespace } // namespace
AudioCodingModule::Config::Config()
: id(0), neteq_config(), clock(Clock::GetRealTimeClock()) {
// Post-decode VAD is disabled by default in NetEq, however, Audio
// Conference Mixer relies on VAD decisions and fails without them.
neteq_config.enable_post_decode_vad = true;
}
AudioCodingModule::Config::Config(const Config&) = default;
AudioCodingModule::Config::~Config() = default;
// Create module // Create module
AudioCodingModule* AudioCodingModule::Create(int id) { AudioCodingModule* AudioCodingModule::Create(int id) {
Config config; Config config;

8
webrtc/modules/audio_coding/include/audio_coding_module.h
View File

@ -64,11 +64,9 @@ class AudioCodingModule {
public: public:
struct Config { struct Config {
Config() : id(0), neteq_config(), clock(Clock::GetRealTimeClock()) { Config();
// Post-decode VAD is disabled by default in NetEq, however, Audio Config(const Config&);
// Conference Mixer relies on VAD decisions and fails without them. ~Config();
neteq_config.enable_post_decode_vad = true;
}
int id; int id;
NetEq::Config neteq_config; NetEq::Config neteq_config;