zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ignore overflowing left shift

Browse Source 
It's audio data, not an index or anything like that, so the most an
overflow can do is make it sound worse.

Bug: chromium:834531
Change-Id: Icb39c1bb011219c1a6fe67bc582390daa2693379
Reviewed-on: https://webrtc-review.googlesource.com/71160
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22947}
This commit is contained in:
Karl Wiberg
2018-04-19 14:07:25 +02:00
committed by Commit Bot
parent e63d38ba34
commit 36b096c38e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/audio_coding/codecs/isac/fix/source/lattice.c
View File

@ -279,8 +279,7 @@ void WebRtcIsacfix_NormLatticeFilterAr(size_t orderCoef,
for (i=0;i<HALF_SUBFRAMELEN;i++) for (i=0;i<HALF_SUBFRAMELEN;i++)
{ {
tmp32 = OverflowingLShiftS32(lat_inQ25[i + temp1], 1); // Q25->Q26
tmp32 = lat_inQ25[i + temp1] * (1 << 1); // Q25->Q26
tmp32 = WEBRTC_SPL_MUL_16_32_RSFT16(inv_gain16, tmp32); //lat_in[]*inv_gain in (Q(18-sh)*Q26)>>16 = Q(28-sh) tmp32 = WEBRTC_SPL_MUL_16_32_RSFT16(inv_gain16, tmp32); //lat_in[]*inv_gain in (Q(18-sh)*Q26)>>16 = Q(28-sh)
tmp32 = WEBRTC_SPL_SHIFT_W32(tmp32, -(28-sh)); // lat_in[]*inv_gain in Q0 tmp32 = WEBRTC_SPL_SHIFT_W32(tmp32, -(28-sh)); // lat_in[]*inv_gain in Q0