From 37ad5ab940b29dcbe9d1cf4cd303fe01c6e2dfbf Mon Sep 17 00:00:00 2001 From: Bjorn A Mellem Date: Fri, 20 Sep 2019 12:38:01 -0700 Subject: [PATCH] Change DatagramTransportInterface methods to pure virtual. These methods are implemented everywhere, and no longer need to provide default implementations. Bug: webrtc:9719 Change-Id: I2b33ace17696ec832a9936cf02a81c4973158046 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154003 Commit-Queue: Bjorn Mellem Commit-Queue: Seth Hampson Reviewed-by: Seth Hampson Cr-Commit-Position: refs/heads/master@{#29263} --- api/transport/datagram_transport_interface.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/api/transport/datagram_transport_interface.h b/api/transport/datagram_transport_interface.h index 9820c7505a..387950e59f 100644 --- a/api/transport/datagram_transport_interface.h +++ b/api/transport/datagram_transport_interface.h @@ -58,11 +58,10 @@ class DatagramSinkInterface { virtual void OnDatagramSent(DatagramId datagram_id) = 0; // Called when datagram is ACKed. - // TODO(sukhanov): Make pure virtual. - virtual void OnDatagramAcked(const DatagramAck& datagram_ack) {} + virtual void OnDatagramAcked(const DatagramAck& datagram_ack) = 0; // Called when a datagram is lost. - virtual void OnDatagramLost(DatagramId datagram_id) {} + virtual void OnDatagramLost(DatagramId datagram_id) = 0; }; // Datagram transport allows to send and receive unreliable packets (datagrams) @@ -140,9 +139,7 @@ class DatagramTransportInterface : public DataChannelTransportInterface { // For clients, the parameters echo the server configuration used to create // the client, possibly removing any fields or parameters which the client // does not understand. - // - // TODO(mellem): Make pure virtual. - virtual std::string GetTransportParameters() const { return ""; } + virtual std::string GetTransportParameters() const = 0; }; } // namespace webrtc