zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use backticks not vertical bars to denote variables in comments for /pc

Browse Source 
Bug: webrtc:12338
Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34575}
This commit is contained in:
Artem Titov
2021-07-26 15:29:11 +02:00
committed by WebRTC LUCI CQ
parent 75ac5ab859
commit 37ee0f5e59
81 changed files with 535 additions and 535 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pc/webrtc_sdp_unittest.cc
View File

@ -907,7 +907,7 @@ static bool SdpDeserializeCandidate(const std::string& message,
return webrtc::SdpDeserializeCandidate(message, candidate, NULL);
}
// Add some extra |newlines| to the |message| after |line|.
// Add some extra `newlines` to the `message` after `line`.
static void InjectAfter(const std::string& line,
const std::string& newlines,
std::string* message) {
@ -920,8 +920,8 @@ static void Replace(const std::string& line,
absl::StrReplaceAll({{line, newlines}}, message);
}
// Expect a parse failure on the line containing |bad_part| when attempting to
// parse |bad_sdp|.
// Expect a parse failure on the line containing `bad_part` when attempting to
// parse `bad_sdp`.
static void ExpectParseFailure(const std::string& bad_sdp,
const std::string& bad_part) {
JsepSessionDescription desc(kDummyType);
@ -932,14 +932,14 @@ static void ExpectParseFailure(const std::string& bad_sdp,
<< "Did not find " << bad_part << " in " << error.line;
}
// Expect fail to parse kSdpFullString if replace |good_part| with |bad_part|.
// Expect fail to parse kSdpFullString if replace `good_part` with `bad_part`.
static void ExpectParseFailure(const char* good_part, const char* bad_part) {
std::string bad_sdp = kSdpFullString;
Replace(good_part, bad_part, &bad_sdp);
ExpectParseFailure(bad_sdp, bad_part);
}
// Expect fail to parse kSdpFullString if add |newlines| after |injectpoint|.
// Expect fail to parse kSdpFullString if add `newlines` after `injectpoint`.
static void ExpectParseFailureWithNewLines(const std::string& injectpoint,
const std::string& newlines,
const std::string& bad_part) {
@ -1583,7 +1583,7 @@ class WebRtcSdpTest : public ::testing::Test {
return true;
}
// Disable the ice-ufrag and ice-pwd in given |sdp| message by replacing
// Disable the ice-ufrag and ice-pwd in given `sdp` message by replacing
// them with invalid keywords so that the parser will just ignore them.
bool RemoveCandidateUfragPwd(std::string* sdp) {
absl::StrReplaceAll(
@ -1591,7 +1591,7 @@ class WebRtcSdpTest : public ::testing::Test {
return true;
}
// Update the candidates in |jdesc| to use the given |ufrag| and |pwd|.
// Update the candidates in `jdesc` to use the given `ufrag` and `pwd`.
bool UpdateCandidateUfragPwd(JsepSessionDescription* jdesc,
int mline_index,
const std::string& ufrag,
@ -2396,7 +2396,7 @@ TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithH264) {
ASSERT_NE(before_pt, std::string::npos);
before_pt += strlen("a=rtpmap:");
std::string pt = message.substr(before_pt, after_pt - before_pt);
// TODO(hta): Check if payload type |pt| occurs in the m=video line.
// TODO(hta): Check if payload type `pt` occurs in the m=video line.
std::string to_find = "a=fmtp:" + pt + " ";
size_t fmtp_pos = message.find(to_find);
ASSERT_NE(std::string::npos, fmtp_pos) << "Failed to find " << to_find;
@ -3670,7 +3670,7 @@ TEST_F(WebRtcSdpTest, SerializeDtlsSetupAttribute) {
// Fingerprint attribute is necessary to add DTLS setup attribute.
InjectAfter(kAttributeIcePwdVoice, kFingerprint, &sdp_with_dtlssetup);
InjectAfter(kAttributeIcePwdVideo, kFingerprint, &sdp_with_dtlssetup);
// Now adding |setup| attribute.
// Now adding `setup` attribute.
InjectAfter(kFingerprint, "a=setup:active\r\n", &sdp_with_dtlssetup);
EXPECT_EQ(sdp_with_dtlssetup, message);
}