zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Consolidate constructormagic macros with Chromium version and remove Chromium override.

Browse Source 
Part of work removing dependency on Chromium's base.

Only adds "= delete". From https://codereview.chromium.org/1151443003 :
"This will guarantee the error to be at compile time, and not rely on the call visibility (private)."

In consequence of that change, fixed an illegal copy and removed a bunch of unused variables.

Depends on https://codereview.webrtc.org/1345433002/

BUG=chromium:468375
(in particular comment #37)
NOTRY=true

Review URL: https://codereview.webrtc.org/1342543004

Cr-Commit-Position: refs/heads/master@{#9954}
This commit is contained in:
henrikg
2015-09-16 06:33:20 -07:00
committed by Commit bot
parent 3c089d751e
commit 384194369b
14 changed files with 16 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
View File

@ -719,8 +719,7 @@ VideoSource::VideoSource(int flow_id,
next_frame_ms_(first_frame_offset_ms),
next_frame_rand_ms_(0),
now_ms_(0),
prototype_header_(),
start_plotting_ms_(first_frame_offset_ms) {
prototype_header_() {
memset(&prototype_header_, 0, sizeof(prototype_header_));
prototype_header_.ssrc = ssrc;
prototype_header_.sequenceNumber = 0xf000u;

3
webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
View File

@ -370,7 +370,6 @@ class ChokeFilter : public PacketProcessor {
uint32_t capacity_kbps_;
int64_t last_send_time_us_;
rtc::scoped_ptr<DelayCapHelper> delay_cap_helper_;
int64_t max_delay_us_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(ChokeFilter);
};
@ -447,8 +446,6 @@ class VideoSource {
int64_t next_frame_rand_ms_;
int64_t now_ms_;
RTPHeader prototype_header_;
int64_t start_plotting_ms_;
uint32_t previous_bitrate_bps_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(VideoSource);
};