zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make WARN_UNUSED_RESULT a no-op on gcc

Browse Source 
Because on gcc, cast to void doesn't silence the warning. See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425

Also add an RTC_ prefix to the macro instead of only defining it if it
wasn't already defined, to ensure that we always get our own version.

BUG=none

Review-Url: https://codereview.webrtc.org/2797983003
Cr-Commit-Position: refs/heads/master@{#17563}
This commit is contained in:
kwiberg
2017-04-06 04:32:27 -07:00
committed by Commit bot
parent 177b17e050
commit 388fe425c7
6 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/base/swap_queue.h
View File

@ -118,7 +118,7 @@ class SwapQueue {
// When specified, the T given in *input must pass the ItemVerifier() test.
// The contents of *input after the call are then also guaranteed to pass the
// ItemVerifier() test.
bool Insert(T* input) WARN_UNUSED_RESULT {
bool Insert(T* input) RTC_WARN_UNUSED_RESULT {
RTC_DCHECK(input);
rtc::CritScope cs(&crit_queue_);
@ -151,7 +151,7 @@ class SwapQueue {
// empty). When specified, The T given in *output must pass the ItemVerifier()
// test and the contents of *output after the call are then also guaranteed to
// pass the ItemVerifier() test.
bool Remove(T* output) WARN_UNUSED_RESULT {
bool Remove(T* output) RTC_WARN_UNUSED_RESULT {
RTC_DCHECK(output);
rtc::CritScope cs(&crit_queue_);