zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Expose NetEqDecodingTest for re-use in chromium tests.

Browse Source 
This CL allows to trigger related tests when rolling opus
(at chromium side). Namely:
* TestOpusBitExactness
* TestOpusDtxBitExactness

This CL also prevents name clash for OpusTest:
* modules/audio_coding/test/opus_test.h: Helper class.
* modules/audio_coding/neteq/opus_unittest.cc: Local test fixture.

Bug: chromium:1002973
Change-Id: If8470b5f64fbdb1f7a84b838bde62d8c90390f2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159033
Commit-Queue: Yves Gerey <yvesg@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29759}
This commit is contained in:
Yves Gerey
2019-11-11 18:05:42 +01:00
committed by Commit Bot
parent 64e07f445a
commit 3a65f392a3
7 changed files with 744 additions and 610 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
modules/audio_coding/BUILD.gn
View File

@ -1187,6 +1187,17 @@ if (rtc_enable_protobuf) {
"../../logging:rtc_event_log_proto",
]
}
# Only used for test purpose. Since we want to use it from chromium
# (see audio_coding_modules_tests_shared below), we cannot guard it
# under rtc_include_tests.
proto_library("neteq_unittest_proto") {
testonly = true
sources = [
"neteq/neteq_unittest.proto",
]
proto_out_dir = "modules/audio_coding/neteq"
}
}
# Allow to re-use some test classes from chromium.
@ -1196,6 +1207,10 @@ rtc_library("audio_coding_modules_tests_shared") {
visibility = [ "*" ]
sources = [
"neteq/test/neteq_decoding_test.cc",
"neteq/test/neteq_decoding_test.h",
"neteq/test/result_sink.cc",
"neteq/test/result_sink.h",
"test/PCMFile.cc",
"test/PCMFile.h",
"test/TestStereo.cc",
@ -1207,20 +1222,36 @@ rtc_library("audio_coding_modules_tests_shared") {
deps = [
":audio_coding",
":audio_coding_module_typedefs",
":neteq_test_tools",
":neteq_tools_minimal",
":webrtc_opus_wrapper",
"..:module_api",
"../../api:neteq_factory_with_codecs",
"../../api:rtp_headers",
"../../api/audio:audio_frame_api",
"../../api/audio_codecs:builtin_audio_decoder_factory",
"../../api/audio_codecs:builtin_audio_encoder_factory",
"../../api/neteq:neteq_api",
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:ignore_wundef",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:stringutils",
"../../system_wrappers",
"../../test:fileutils",
"../../test:test_support",
"../rtp_rtcp:rtp_rtcp_format",
"//testing/gtest",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
defines = audio_coding_defines
if (rtc_enable_protobuf) {
defines += [ "WEBRTC_NETEQ_UNITTEST_BITEXACT" ]
deps += [ ":neteq_unittest_proto" ]
}
}
if (rtc_include_tests) {
@ -1475,13 +1506,6 @@ if (rtc_include_tests) {
}
if (rtc_enable_protobuf) {
proto_library("neteq_unittest_proto") {
sources = [
"neteq/neteq_unittest.proto",
]
proto_out_dir = "modules/audio_coding/neteq"
}
rtc_library("neteq_test_factory") {
testonly = true
visibility += webrtc_default_visibility
@ -2026,6 +2050,7 @@ if (rtc_include_tests) {
":acm_send_test",
":audio_coding",
":audio_coding_module_typedefs",
":audio_coding_modules_tests_shared",
":audio_coding_opus_common",
":audio_encoder_cng",
":audio_network_adaptor",