zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AEC3: Ensure that the high-pass filter effect is on when AEC3 is active

Browse Source 
This CL ensures that the high-pass filter is on whenever the echo
controller is on. This is important as the echo controller code assumes
that the external high-pass filter is active.

The CL also corrects the ToggleAec unit test (which started failing
after this code change).

Bug: webrtc:11159,chromium:1030179
Change-Id: Ie29db74bf3de6279a08564398d32d67d5e1569db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161222
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29979}
This commit is contained in:
Per Åhgren
2019-12-03 11:15:18 +01:00
committed by Commit Bot
parent 014dd3c9f7
commit 3a77f93589
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/audio_processing/test/debug_dump_test.cc
View File

@ -51,8 +51,8 @@ class DebugDumpGenerator {
bool enable_pre_amplifier);
// Constructor that uses default input files.
explicit DebugDumpGenerator(const Config& config,
const AudioProcessing::Config& apm_config);
DebugDumpGenerator(const Config& config,
const AudioProcessing::Config& apm_config);
~DebugDumpGenerator();
@ -346,7 +346,7 @@ TEST_F(DebugDumpTest, ToggleAec) {
generator.StartRecording();
generator.Process(100);
apm_config.echo_canceller.enabled = true;
apm_config.echo_canceller.enabled = false;
generator.apm()->ApplyConfig(apm_config);
generator.Process(100);