zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."

Browse Source 
This reverts commit 2148e9a931ea1a8a2ac0bfffd56e12370f8bf18c.

Reason for revert: Breaks linux-libfuzzer-asan-rel,
https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/326226. I will export symbols in this CL when relanding.

Original change's description:
> Make webrtc_fuzzer_main depend on webrtc_component in Chromium.
> 
> This is needed in order to land [1] and restrict visibility of some
> //third_party/webrtc_overrides targets.
> 
> [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1930801
> 
> Bug: chromium:896154
> Change-Id: Ie71c44ee9a0203a85d77a1199acdcb8581dfb71b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160308
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29875}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I1000e90e687d01c29a9ec4a3c8ded646b97fcaab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:896154
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160400
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29885}
This commit is contained in:
Mirko Bonadei
2019-11-23 08:41:42 +00:00
committed by Commit Bot
parent 1833a0c8a7
commit 3af0cd8de2
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/fuzzers/BUILD.gn
View File

@ -15,12 +15,17 @@ rtc_library("webrtc_fuzzer_main") {
"webrtc_fuzzer_main.cc",
]
deps = [
"../../rtc_base:rtc_base_approved",
"//testing/libfuzzer:libfuzzer_main",
]
# When WebRTC fuzzer tests are built on Chromium bots they need to link
# with Chromium's implementation of metrics and field trial.
if (build_with_chromium) {
deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
} else {
deps += [ "../../rtc_base:rtc_base_approved" ]
deps += [
"../../../webrtc_overrides:field_trial",
"../../../webrtc_overrides:metrics",
]
}
}