zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix MSVC warnings about value truncations, webrtc/common_audio/ edition.

Browse Source 
This changes some method signatures to better reflect how callers are actually
using them.  This also has the tendency to make signatures more consistent about
e.g. using int (instead of int16_t) for lengths of things like vectors, and
using int16_t (instead of int) for e.g. counts of bits in a value.

This also removes a couple of functions that were only called in unittests.

BUG=3353,chromium:81439
TEST=none
R=andrew@webrtc.org, bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7060 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
bjornv@webrtc.org
2014-09-04 13:21:44 +00:00
parent f6ab6f86e7
commit 3cbd6c26c8
15 changed files with 82 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
webrtc/common_audio/signal_processing/copy_set_operations.c
View File

@ -17,8 +17,6 @@
* WebRtcSpl_CopyFromEndW16()
* WebRtcSpl_ZerosArrayW16()
* WebRtcSpl_ZerosArrayW32()
* WebRtcSpl_OnesArrayW16()
* WebRtcSpl_OnesArrayW32()
*
* The description header can be found in signal_processing_library.h
*
@ -62,47 +60,21 @@ void WebRtcSpl_MemCpyReversedOrder(int16_t* dest, int16_t* source, int length)
}
}
int16_t WebRtcSpl_CopyFromEndW16(const int16_t *vector_in,
int16_t length,
int16_t samples,
int16_t *vector_out)
void WebRtcSpl_CopyFromEndW16(const int16_t *vector_in,
int length,
int samples,
int16_t *vector_out)
{
// Copy the last <samples> of the input vector to vector_out
WEBRTC_SPL_MEMCPY_W16(vector_out, &vector_in[length - samples], samples);
return samples;
}
int16_t WebRtcSpl_ZerosArrayW16(int16_t *vector, int16_t length)
void WebRtcSpl_ZerosArrayW16(int16_t *vector, int length)
{
WebRtcSpl_MemSetW16(vector, 0, length);
return length;
}
int16_t WebRtcSpl_ZerosArrayW32(int32_t *vector, int16_t length)
void WebRtcSpl_ZerosArrayW32(int32_t *vector, int length)
{
WebRtcSpl_MemSetW32(vector, 0, length);
return length;
}
int16_t WebRtcSpl_OnesArrayW16(int16_t *vector, int16_t length)
{
int16_t i;
int16_t *tmpvec = vector;
for (i = 0; i < length; i++)
{
*tmpvec++ = 1;
}
return length;
}
int16_t WebRtcSpl_OnesArrayW32(int32_t *vector, int16_t length)
{
int16_t i;
int32_t *tmpvec = vector;
for (i = 0; i < length; i++)
{
*tmpvec++ = 1;
}
return length;
}