zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove media/base/h264_profile_level_id.* and media/base/vp9_profile.h

Browse Source 
The content of these files was moved to api/video_codecs in
https://webrtc.googlesource.com/src.git/+/c3fcee7c3a7714afc3e37d4753b40f4fdbc3653e
but the original files could not be removed due to dependencies
in downstream projects.

Bug: chromium:1187565
Change-Id: I414efa22102bfdea0765fa72a8cf8b0bd5c090db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229303
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34869}
This commit is contained in:
Johannes Kron
2021-08-19 12:13:06 +02:00
committed by WebRTC LUCI CQ
parent 9ad972d4fb
commit 3cd7a0ffdd
15 changed files with 25 additions and 296 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
api/video_codecs/test/BUILD.gn
View File

@ -26,6 +26,7 @@ if (rtc_include_tests) {
"../..:fec_controller_api",
"../..:mock_video_encoder",
"../../../api:scoped_refptr",
"../../../media:rtc_media_base",
"../../../modules/video_coding:video_codec_interface",
"../../../modules/video_coding:video_coding_utility",
"../../../modules/video_coding:webrtc_vp8",

15
api/video_codecs/test/sdp_video_format_unittest.cc
View File

@ -12,6 +12,7 @@
#include <stdint.h>
#include "media/base/media_constants.h"
#include "test/gtest.h"
namespace webrtc {
@ -25,11 +26,13 @@ TEST(SdpVideoFormatTest, SameCodecNameNoParameters) {
EXPECT_TRUE(Sdp("Vp9").IsSameCodec(Sdp("vp9")));
EXPECT_TRUE(Sdp("AV1").IsSameCodec(Sdp("Av1")));
}
TEST(SdpVideoFormatTest, DifferentCodecNameNoParameters) {
EXPECT_FALSE(Sdp("H264").IsSameCodec(Sdp("VP8")));
EXPECT_FALSE(Sdp("VP8").IsSameCodec(Sdp("VP9")));
EXPECT_FALSE(Sdp("AV1").IsSameCodec(Sdp("")));
}
TEST(SdpVideoFormatTest, SameCodecNameSameParameters) {
EXPECT_TRUE(Sdp("VP9").IsSameCodec(Sdp("VP9", Params{{"profile-id", "0"}})));
EXPECT_TRUE(Sdp("VP9", Params{{"profile-id", "0"}})
@ -71,4 +74,16 @@ TEST(SdpVideoFormatTest, DifferentCodecNameSameParameters) {
.IsSameCodec(Sdp("VP8", Params{{"profile-level-id", "640c34"}})));
}
TEST(SdpVideoFormatTest, H264PacketizationMode) {
// The default packetization mode is 0.
EXPECT_TRUE(Sdp("H264", Params{{cricket::kH264FmtpPacketizationMode, "0"}})
.IsSameCodec(Sdp("H264")));
EXPECT_FALSE(Sdp("H264", Params{{cricket::kH264FmtpPacketizationMode, "1"}})
.IsSameCodec(Sdp("H264")));
EXPECT_TRUE(
Sdp("H264", Params{{cricket::kH264FmtpPacketizationMode, "1"}})
.IsSameCodec(
Sdp("H264", Params{{cricket::kH264FmtpPacketizationMode, "1"}})));
}
} // namespace webrtc