zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark all virtual overrides in the hierarchy of Transport as virtual + OVERRIDE.

Browse Source 
This also marks all virtual overrides of other classes in the same files. 

This will make a subsequent change I intend to do safer, where I'll change the 
argument types of the base Transport functions, by breaking the compile if I 
miss any overrides. 

This also highlighted a number of unused functions. I've removed some of these. 

TBR=mflodman@webrtc.org, pkasting@chromium.org
BUG=none 
TEST=none

Review URL: https://webrtc-codereview.appspot.com/28709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7421 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
xians@webrtc.org
2014-10-10 09:42:53 +00:00
parent afede835ee
commit 3cefbc99f4
29 changed files with 222 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
View File

@ -39,20 +39,24 @@ class TestTransport : public Transport,
void SetRTCPReceiver(RTCPReceiver* rtcp_receiver) {
rtcp_receiver_ = rtcp_receiver;
}
virtual int SendPacket(int /*ch*/, const void* /*data*/, int /*len*/) {
virtual int SendPacket(int /*ch*/,
const void* /*data*/,
int /*len*/) OVERRIDE {
ADD_FAILURE(); // FAIL() gives a compile error.
return -1;
}
// Injects an RTCP packet into the receiver.
virtual int SendRTCPPacket(int /* ch */, const void *packet, int packet_len) {
virtual int SendRTCPPacket(int /* ch */,
const void *packet,
int packet_len) OVERRIDE {
ADD_FAILURE();
return 0;
}
virtual int OnReceivedPayloadData(const uint8_t* payloadData,
const uint16_t payloadSize,
const WebRtcRTPHeader* rtpHeader) {
const WebRtcRTPHeader* rtpHeader) OVERRIDE {
ADD_FAILURE();
return 0;
}
@ -818,7 +822,7 @@ TEST_F(RtcpReceiverTest, Callbacks) {
virtual ~RtcpCallbackImpl() {}
virtual void StatisticsUpdated(const RtcpStatistics& statistics,
uint32_t ssrc) {
uint32_t ssrc) OVERRIDE {
stats_ = statistics;
ssrc_ = ssrc;
}