zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing -Wsign-compare errors.

Browse Source 
Error example:
absl/types/optional.h:1107:54: error: comparison of integers of
different signs: 'const unsigned long' and 'const int'
[-Werror,-Wsign-compare]
[...]
EXPECT_GT(streams[0].num_temporal_layers, 1);

Bug: None
Change-Id: Ifa84e318e242d0dfb32a4f2166464d91fcc86fb1
Reviewed-on: https://webrtc-review.googlesource.com/89744
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24060}
This commit is contained in:
Mirko Bonadei
2018-07-20 15:35:41 +02:00
committed by Commit Bot
parent 94ef424b31
commit 3d72f6dac8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
media/engine/simulcast_unittest.cc
View File

@ -93,7 +93,7 @@ TEST(SimulcastTest, GetConfig) {
EXPECT_EQ(720u, streams[2].height);
for (size_t i = 0; i < streams.size(); ++i) {
EXPECT_EQ(kDefaultTemporalLayers, streams[i].num_temporal_layers);
EXPECT_EQ(size_t{kDefaultTemporalLayers}, streams[i].num_temporal_layers);
EXPECT_EQ(kMaxFps, streams[i].max_framerate);
EXPECT_EQ(kQpMax, streams[i].max_qp);
EXPECT_EQ(kExpected[i].min_bitrate_bps, streams[i].min_bitrate_bps);
@ -148,7 +148,7 @@ TEST(SimulcastTest, GetConfigForScreenshare) {
EXPECT_EQ(kQpMax, streams[0].max_qp);
EXPECT_EQ(kBitratePriority, streams[0].bitrate_priority);
EXPECT_TRUE(streams[0].active);
EXPECT_GT(streams[0].num_temporal_layers, 1);
EXPECT_GT(streams[0].num_temporal_layers, size_t{1});
EXPECT_GT(streams[0].max_framerate, 0);
EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
EXPECT_GT(streams[0].target_bitrate_bps, streams[0].min_bitrate_bps);
@ -167,7 +167,7 @@ TEST(SimulcastTest, GetConfigForScreenshareSimulcast) {
EXPECT_EQ(800u, streams[i].height) << "Screen content never scaled.";
EXPECT_EQ(kQpMax, streams[i].max_qp);
EXPECT_TRUE(streams[i].active);
EXPECT_GT(streams[i].num_temporal_layers, 1);
EXPECT_GT(streams[i].num_temporal_layers, size_t{1});
EXPECT_GT(streams[i].max_framerate, 0);
EXPECT_GT(streams[i].min_bitrate_bps, 0);
EXPECT_GT(streams[i].target_bitrate_bps, streams[i].min_bitrate_bps);