zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove -Wno-sign-compare, -Wno-unused-variable and -Wno-format.

Browse Source 
Bug: webrtc:9251
Change-Id: Ide719100cb99fdf5fe6700af9d5f4a1884ac2b67
Reviewed-on: https://webrtc-review.googlesource.com/87842
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23905}
This commit is contained in:
Mirko Bonadei
2018-07-10 14:21:23 +02:00
committed by Commit Bot
parent 1a4746a563
commit 3e603ec4a6
3 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
examples/BUILD.gn
View File

@ -224,14 +224,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
config("apprtc_signaling_config") { config("apprtc_signaling_config") {
include_dirs = [ "objc/AppRTCMobile" ] include_dirs = [ "objc/AppRTCMobile" ]
# GN orders flags on a target before flags from configs. The default config
# adds these flags so to cancel them out they need to come from a config and
# cannot be on the target directly.
cflags = [
"-Wno-sign-compare",
"-Wno-unused-variable",
]
} }
rtc_static_library("apprtc_signaling") { rtc_static_library("apprtc_signaling") {
@ -681,14 +673,9 @@ if (is_linux || is_win) {
cflags = [] cflags = []
if (is_win && is_clang) { if (is_win && is_clang) {
cflags += [ cflags += [
# Disable warnings failing when compiling with Clang on Windows.
# https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
"-Wno-format",
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6271 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6271
# for -Wno-reorder and -Wno-sign-compare # for -Wno-reorder and -Wno-sign-compare
"-Wno-reorder", "-Wno-reorder",
"-Wno-sign-compare",
] ]
} }
if (is_linux && target_cpu == "x86") { if (is_linux && target_cpu == "x86") {

2
examples/objc/AppRTCMobile/ARDAppClient.m
View File

@ -54,10 +54,12 @@ static NSString * const kARDVideoTrackId = @"ARDAMSv0";
static NSString * const kARDVideoTrackKind = @"video"; static NSString * const kARDVideoTrackKind = @"video";
// TODO(tkchin): Add these as UI options. // TODO(tkchin): Add these as UI options.
#if defined(WEBRTC_IOS)
static BOOL const kARDAppClientEnableTracing = NO; static BOOL const kARDAppClientEnableTracing = NO;
static BOOL const kARDAppClientEnableRtcEventLog = YES; static BOOL const kARDAppClientEnableRtcEventLog = YES;
static int64_t const kARDAppClientAecDumpMaxSizeInBytes = 5e6; // 5 MB. static int64_t const kARDAppClientAecDumpMaxSizeInBytes = 5e6; // 5 MB.
static int64_t const kARDAppClientRtcEventLogMaxSizeInBytes = 5e6; // 5 MB. static int64_t const kARDAppClientRtcEventLogMaxSizeInBytes = 5e6; // 5 MB.
#endif
static int const kKbpsMultiplier = 1000; static int const kKbpsMultiplier = 1000;
// We need a proxy to NSTimer because it causes a strong retain cycle. When // We need a proxy to NSTimer because it causes a strong retain cycle. When

2
examples/objc/AppRTCMobile/ARDAppEngineClient.m
View File

@ -55,7 +55,6 @@ static NSInteger const kARDAppEngineClientErrorBadResponse = -1;
RTCLog(@"Joining room:%@ on room server.", roomId); RTCLog(@"Joining room:%@ on room server.", roomId);
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:roomURL]; NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:roomURL];
request.HTTPMethod = @"POST"; request.HTTPMethod = @"POST";
__weak ARDAppEngineClient *weakSelf = self;
[NSURLConnection sendAsyncRequest:request [NSURLConnection sendAsyncRequest:request
completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) { completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) {
if (error) { if (error) {
@ -96,7 +95,6 @@ static NSInteger const kARDAppEngineClientErrorBadResponse = -1;
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url]; NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
request.HTTPMethod = @"POST"; request.HTTPMethod = @"POST";
request.HTTPBody = data; request.HTTPBody = data;
__weak ARDAppEngineClient *weakSelf = self;
[NSURLConnection sendAsyncRequest:request [NSURLConnection sendAsyncRequest:request
completionHandler:^(NSURLResponse *response, completionHandler:^(NSURLResponse *response,
NSData *data, NSData *data,