zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix error when accumulating floats in an int.

Browse Source 
I saw this when browsing the code, I think the intended behavior is accumulating to a float.

BUG=none

Review-Url: https://codereview.webrtc.org/2268163004
Cr-Commit-Position: refs/heads/master@{#13918}
This commit is contained in:
maxmorin
2016-08-25 04:00:20 -07:00
committed by Commit bot
parent e29352bb34
commit 3f746ea26a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_processing/level_controller/level_controller.cc
View File

@ -35,7 +35,7 @@ void UpdateAndRemoveDcLevel(float forgetting_factor,
rtc::ArrayView<float> x) { rtc::ArrayView<float> x) {
RTC_DCHECK(!x.empty()); RTC_DCHECK(!x.empty());
float mean = float mean =
std::accumulate(x.begin(), x.end(), 0) / static_cast<float>(x.size()); std::accumulate(x.begin(), x.end(), 0.0f) / static_cast<float>(x.size());
*dc_level += forgetting_factor * (mean - *dc_level); *dc_level += forgetting_factor * (mean - *dc_level);
for (float& v : x) { for (float& v : x) {