zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RTCPSender: remove compatibility ctor & method.

Browse Source 
This change removes compatibility APIs in RTCPSender now
that downstream consumers updated.

Bug: webrtc:11581, webrtc:6458
Change-Id: I82d70f1ab6b522b3884480b0b16cbdff9a1490c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222323
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34356}
This commit is contained in:
Markus Handell
2021-06-22 11:57:08 +02:00
committed by WebRTC LUCI CQ
parent 49cb459956
commit 3f7b7170cc
2 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
modules/rtp_rtcp/source/rtcp_sender.cc
View File

@ -186,9 +186,6 @@ RTCPSender::RTCPSender(Configuration config)
builders_[kRtcpAnyExtendedReports] = &RTCPSender::BuildExtendedReports;
}
RTCPSender::RTCPSender(const RtpRtcpInterface::Configuration& config)
: RTCPSender(Configuration::FromRtpRtcpConfiguration(config)) {}
RTCPSender::~RTCPSender() {}
RtcpMode RTCPSender::Status() const {
@ -328,16 +325,6 @@ void RTCPSender::SetLastRtpTime(uint32_t rtp_timestamp,
}
}
void RTCPSender::SetLastRtpTime(uint32_t rtp_timestamp,
int64_t capture_time_ms,
int8_t payload_type) {
absl::optional<int8_t> payload_type_optional;
if (payload_type != -1)
payload_type_optional = payload_type;
SetLastRtpTime(rtp_timestamp, Timestamp::Millis(capture_time_ms),
payload_type_optional);
}
void RTCPSender::SetRtpClockRate(int8_t payload_type, int rtp_clock_rate_hz) {
MutexLock lock(&mutex_rtcp_sender_);
rtp_clock_rates_khz_[payload_type] = rtp_clock_rate_hz / 1000;

11
modules/rtp_rtcp/source/rtcp_sender.h
View File

@ -98,9 +98,6 @@ class RTCPSender final {
};
explicit RTCPSender(Configuration config);
// TODO(bugs.webrtc.org/11581): delete this temporary compatibility helper
// once downstream dependencies migrates.
explicit RTCPSender(const RtpRtcpInterface::Configuration& config);
RTCPSender() = delete;
RTCPSender(const RTCPSender&) = delete;
@ -125,14 +122,6 @@ class RTCPSender final {
absl::optional<Timestamp> capture_time,
absl::optional<int8_t> payload_type)
RTC_LOCKS_EXCLUDED(mutex_rtcp_sender_);
// TODO(bugs.webrtc.org/6458): Remove default parameter value when all the
// depending projects are updated to correctly set payload type.
// TODO(bugs.webrtc.org/12873): Remove once downstream consumers migrates to
// the new version of SetLastRtpTime declared above.
void SetLastRtpTime(uint32_t rtp_timestamp,
int64_t capture_time_ms,
int8_t payload_type = -1)
RTC_LOCKS_EXCLUDED(mutex_rtcp_sender_);
void SetRtpClockRate(int8_t payload_type, int rtp_clock_rate_hz)
RTC_LOCKS_EXCLUDED(mutex_rtcp_sender_);