zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ChangeUniqueID.

Browse Source 
This fixes a two year old TODO of deleting dead code :)
In cases where the _id or id_ member variable is being used for tracing,
I changed the member to at least be const.

It doesn't look like id's are that useful anymore so maybe the next step is to get rid of them.

BUG=
R=henrika@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37849004

Cr-Commit-Position: refs/heads/master@{#8201}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8201 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org
2015-01-29 12:12:49 +00:00
parent 1ece0cbbec
commit 4161715e3f
71 changed files with 32 additions and 392 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc
View File

@ -222,22 +222,6 @@ AudioCodingModuleImpl::~AudioCodingModuleImpl() {
"Destroyed");
}
int32_t AudioCodingModuleImpl::ChangeUniqueId(const int32_t id) {
{
CriticalSectionScoped lock(acm_crit_sect_);
id_ = id;
for (int i = 0; i < ACMCodecDB::kMaxNumCodecs; i++) {
if (codecs_[i] != NULL) {
codecs_[i]->SetUniqueID(id);
}
}
}
receiver_.set_id(id_);
return 0;
}
// Returns the number of milliseconds until the module want a
// worker thread to call Process.
int64_t AudioCodingModuleImpl::TimeUntilNextProcess() {

3
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h
View File

@ -35,9 +35,6 @@ class AudioCodingModuleImpl : public AudioCodingModule {
explicit AudioCodingModuleImpl(const AudioCodingModule::Config& config);
~AudioCodingModuleImpl();
// Change the unique identifier of this object.
virtual int32_t ChangeUniqueId(const int32_t id) OVERRIDE;
// Returns the number of milliseconds until the module want a worker thread
// to call Process.
virtual int64_t TimeUntilNextProcess() OVERRIDE;