From 416631f119b566c3f4eb01e7bea44395f10bd67a Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Mon, 7 Sep 2020 13:06:38 +0200 Subject: [PATCH] Fix makedirs error in swarming task when directory already exists. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://chromium-swarm.appspot.com/task?id=4e80a4186ad0b110 This regression was added with the below change: https://webrtc-review.googlesource.com/c/src/+/182920 Bug: webrtc:11895 Change-Id: Ic870e2b75e72453acac20e1321a24a8b615c7f58 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183448 Reviewed-by: Mirko Bonadei Reviewed-by: Björn Terelius Commit-Queue: Jeremy Leconte Cr-Commit-Position: refs/heads/master@{#32048} --- tools_webrtc/flags_compatibility.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools_webrtc/flags_compatibility.py b/tools_webrtc/flags_compatibility.py index 2a991c9599..63e3f1fb19 100644 --- a/tools_webrtc/flags_compatibility.py +++ b/tools_webrtc/flags_compatibility.py @@ -24,7 +24,9 @@ def main(): if args.isolated_script_test_perf_output: # TODO(bugs.webrtc.org/11895): Move this code somewhere else because # flags_compatibility.py shouldn't create output directories. - os.makedirs(os.path.dirname(args.isolated_script_test_perf_output)) + output_dirname = os.path.dirname(args.isolated_script_test_perf_output) + if not os.path.exists(output_dirname): + os.makedirs(output_dirname) test_command += ['--isolated_script_test_perf_output=' + args.isolated_script_test_perf_output] logging.info('Running %r', test_command)