zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Making ECDSA the default certificate regardless of WEBRTC_CHROMIUM_BUILD.

Browse Source 
Due to the experiment in chromium relying on KT_DEFAULT = KT_RSA (bug:
crbug.com/611698) a conditional was introduced. Now that the experiment is
ending and the experiment flag has been removed we can make KT_DEFAULT=KT_ECDSA
unconditionally.

BUG=chromium:611698

Review-Url: https://codereview.webrtc.org/2009533003
Cr-Commit-Position: refs/heads/master@{#12935}
This commit is contained in:
hbos
2016-05-26 15:23:16 -07:00
committed by Commit bot
parent 7e1b8fbb45
commit 41c5cd02fc
1 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/base/sslidentity.h
View File

@ -117,20 +117,7 @@ class SSLCertChain {
// KT_LAST is intended for vector declarations and loops over all key types; // KT_LAST is intended for vector declarations and loops over all key types;
// it does not represent any key type in itself. // it does not represent any key type in itself.
// KT_DEFAULT is used as the default KeyType for KeyParams. // KT_DEFAULT is used as the default KeyType for KeyParams.
enum KeyType { enum KeyType { KT_RSA, KT_ECDSA, KT_LAST, KT_DEFAULT = KT_ECDSA };
KT_RSA, KT_ECDSA, KT_LAST,
#if defined(WEBRTC_CHROMIUM_BUILD)
// TODO(hbos): Because of an experiment running in Chromium which relies on
// RSA being the default (for performance reasons) we have this #if. ECDSA
// launches in Chromium by flipping a flag which overrides the default. As
// soon as the experiment has ended and there is no risk of RSA being the
// default we should make KT_DEFAULT = KT_ECDSA unconditionally.
// crbug.com/611698
KT_DEFAULT = KT_RSA
#else
KT_DEFAULT = KT_ECDSA
#endif
};
static const int kRsaDefaultModSize = 1024; static const int kRsaDefaultModSize = 1024;
static const int kRsaDefaultExponent = 0x10001; // = 2^16+1 = 65537 static const int kRsaDefaultExponent = 0x10001; // = 2^16+1 = 65537