zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename some variables and methods in RTC event log.

Browse Source 
Rename loss based and delay based bwe updates in proto (and correspondingly in the C++ code).

BUG=webrtc:6423

Review-Url: https://codereview.webrtc.org/2705613002
Cr-Commit-Position: refs/heads/master@{#16719}
This commit is contained in:
terelius
2017-02-20 05:14:41 -08:00
committed by Commit bot
parent 21e4e0b0ab
commit 424e6cfd58
14 changed files with 114 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
webrtc/tools/event_log_visualizer/analyzer.cc
View File

@ -435,24 +435,24 @@ EventLogAnalyzer::EventLogAnalyzer(const ParsedRtcEventLog& log)
case ParsedRtcEventLog::LOG_END: {
break;
}
case ParsedRtcEventLog::BWE_PACKET_LOSS_EVENT: {
BwePacketLossEvent bwe_update;
case ParsedRtcEventLog::AUDIO_PLAYOUT_EVENT: {
break;
}
case ParsedRtcEventLog::LOSS_BASED_BWE_UPDATE: {
LossBasedBweUpdate bwe_update;
bwe_update.timestamp = parsed_log_.GetTimestamp(i);
parsed_log_.GetBwePacketLossEvent(i, &bwe_update.new_bitrate,
&bwe_update.fraction_loss,
&bwe_update.expected_packets);
parsed_log_.GetLossBasedBweUpdate(i, &bwe_update.new_bitrate,
&bwe_update.fraction_loss,
&bwe_update.expected_packets);
bwe_loss_updates_.push_back(bwe_update);
break;
}
case ParsedRtcEventLog::DELAY_BASED_BWE_UPDATE: {
break;
}
case ParsedRtcEventLog::AUDIO_NETWORK_ADAPTATION_EVENT: {
break;
}
case ParsedRtcEventLog::BWE_PACKET_DELAY_EVENT: {
break;
}
case ParsedRtcEventLog::AUDIO_PLAYOUT_EVENT: {
break;
}
case ParsedRtcEventLog::UNKNOWN_EVENT: {
break;
}

4
webrtc/tools/event_log_visualizer/analyzer.h
View File

@ -45,7 +45,7 @@ struct LoggedRtcpPacket {
std::unique_ptr<rtcp::RtcpPacket> packet;
};
struct BwePacketLossEvent {
struct LossBasedBweUpdate {
uint64_t timestamp;
int32_t new_bitrate;
uint8_t fraction_loss;
@ -150,7 +150,7 @@ class EventLogAnalyzer {
std::map<StreamId, std::vector<LoggedRtcpPacket>> rtcp_packets_;
// A list of all updates from the send-side loss-based bandwidth estimator.
std::vector<BwePacketLossEvent> bwe_loss_updates_;
std::vector<LossBasedBweUpdate> bwe_loss_updates_;
// Window and step size used for calculating moving averages, e.g. bitrate.
// The generated data points will be |step_| microseconds apart.