diff --git a/pc/BUILD.gn b/pc/BUILD.gn index f32c7dd25c..58e27c0b05 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -189,11 +189,8 @@ rtc_static_library("peerconnection") { "../call:call_interfaces", "../common_video:common_video", "../logging:rtc_event_log_api", - "../media:rtc_audio_video", "../media:rtc_data", - "../media:rtc_internal_video_codecs", "../media:rtc_media_base", - "../modules/audio_device", "../p2p:rtc_p2p", "../rtc_base:checks", "../rtc_base:rtc_base", diff --git a/pc/channel.cc b/pc/channel.cc index 6d78c5697f..0c1434d615 100644 --- a/pc/channel.cc +++ b/pc/channel.cc @@ -26,6 +26,9 @@ #include "rtc_base/networkroute.h" #include "rtc_base/ptr_util.h" #include "rtc_base/trace_event.h" +// Adding 'nogncheck' to disable the gn include headers check to support modular +// WebRTC build targets. +#include "media/engine/webrtcvoiceengine.h" // nogncheck #include "p2p/base/packettransportinternal.h" #include "pc/channelmanager.h" #include "pc/rtpmediautils.h" diff --git a/pc/peerconnectionfactory.cc b/pc/peerconnectionfactory.cc index 13fdd9b15a..d9fcce2ae6 100644 --- a/pc/peerconnectionfactory.cc +++ b/pc/peerconnectionfactory.cc @@ -25,10 +25,14 @@ #include "rtc_base/bind.h" #include "rtc_base/checks.h" #include "rtc_base/ptr_util.h" -#include "media/engine/webrtcmediaengine.h" -#include "media/engine/webrtcvideodecoderfactory.h" -#include "media/engine/webrtcvideoencoderfactory.h" -#include "modules/audio_device/include/audio_device.h" +// Adding 'nogncheck' to disable the gn include headers check to support modular +// WebRTC build targets. +// TODO(zhihuang): This wouldn't be necessary if the interface and +// implementation of the media engine were in separate build targets. +#include "media/engine/webrtcmediaengine.h" // nogncheck +#include "media/engine/webrtcvideodecoderfactory.h" // nogncheck +#include "media/engine/webrtcvideoencoderfactory.h" // nogncheck +#include "modules/audio_device/include/audio_device.h" // nogncheck #include "p2p/base/basicpacketsocketfactory.h" #include "p2p/client/basicportallocator.h" #include "pc/audiotrack.h" diff --git a/pc/rtpsender.h b/pc/rtpsender.h index fb2cbfaa7e..119d91f11a 100644 --- a/pc/rtpsender.h +++ b/pc/rtpsender.h @@ -23,8 +23,9 @@ #include "api/rtpsenderinterface.h" #include "rtc_base/basictypes.h" #include "rtc_base/criticalsection.h" -#include "media/base/audiosource.h" -#include "pc/channel.h" +// Adding 'nogncheck' to disable the gn include headers check to support modular +// WebRTC build targets. +#include "media/base/audiosource.h" // nogncheck #include "pc/dtmfsender.h" #include "pc/statscollector.h"