zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused code in APM

Browse Source 
- The injection of the AGC2 level estimator into `AgcManagerDirect`
  is not used anymore
- `ExperimentalAgc::enabled_agc2_level_estimator` can also be removed
- 3 ctors of `ExperimentalAgc` are unused
- `AgcManagerDirectStandaloneTest::AgcMinMicLevelExperiment` can be
  split into separate unit tests (better code clarity)

Bug: webrtc:7494
Change-Id: I5843147c38cf7cb5ee484b0a72fe13dcf363efaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202025
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33027}
This commit is contained in:
Alessio Bazzica
2021-01-15 16:41:48 +01:00
committed by Commit Bot
parent 111a3712e7
commit 42eef86c4f
14 changed files with 84 additions and 266 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/audio_processing/audio_processing_unittest.cc
View File

@ -2931,10 +2931,6 @@ TEST(AudioProcessing, GainController1ConfigEqual) {
b_analog.clipped_level_min = a_analog.clipped_level_min;
EXPECT_EQ(a, b);
Toggle(a_analog.enable_agc2_level_estimator);
b_analog.enable_agc2_level_estimator = a_analog.enable_agc2_level_estimator;
EXPECT_EQ(a, b);
Toggle(a_analog.enable_digital_adaptive);
b_analog.enable_digital_adaptive = a_analog.enable_digital_adaptive;
EXPECT_EQ(a, b);
@ -2989,10 +2985,6 @@ TEST(AudioProcessing, GainController1ConfigNotEqual) {
EXPECT_NE(a, b);
a_analog.clipped_level_min = b_analog.clipped_level_min;
Toggle(a_analog.enable_agc2_level_estimator);
EXPECT_NE(a, b);
a_analog.enable_agc2_level_estimator = b_analog.enable_agc2_level_estimator;
Toggle(a_analog.enable_digital_adaptive);
EXPECT_NE(a, b);
a_analog.enable_digital_adaptive = b_analog.enable_digital_adaptive;