zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code"

Browse Source 
This reverts commit 8c2250eddc7263036397179a0794b9b17d7afb38.

Reason for revert: breaks downstream project

Original change's description:
> Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code
>
> Bug: webrtc:12336
> Change-Id: If76f00d0883b5c8a90d3ef5554f5e22384b3fb58
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/197620
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32978}

TBR=danilchap@webrtc.org,mbonadei@webrtc.org,crodbro@webrtc.org

Change-Id: I5c9d419785254878a825865808b56841cd30b9b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12336
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201731
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32979}
This commit is contained in:
Danil Chapovalov
2021-01-14 15:02:22 +00:00
committed by Commit Bot
parent 8c2250eddc
commit 4319b1695e
13 changed files with 31 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/rtp_rtcp/source/rtcp_packet/loss_notification.h
View File

@ -11,9 +11,9 @@
#ifndef MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_LOSS_NOTIFICATION_H_
#define MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_LOSS_NOTIFICATION_H_
#include "absl/base/attributes.h"
#include "modules/rtp_rtcp/source/rtcp_packet/common_header.h"
#include "modules/rtp_rtcp/source/rtcp_packet/psfb.h"
#include "rtc_base/system/unused.h"
namespace webrtc {
namespace rtcp {
@ -29,15 +29,14 @@ class LossNotification : public Psfb {
size_t BlockLength() const override;
ABSL_MUST_USE_RESULT
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
PacketReadyCallback callback) const override;
PacketReadyCallback callback) const override
RTC_WARN_UNUSED_RESULT;
// Parse assumes header is already parsed and validated.
ABSL_MUST_USE_RESULT
bool Parse(const CommonHeader& packet);
bool Parse(const CommonHeader& packet) RTC_WARN_UNUSED_RESULT;
// Set all of the values transmitted by the loss notification message.
// If the values may not be represented by a loss notification message,
@ -45,10 +44,9 @@ class LossNotification : public Psfb {
// when |last_recieved| is ahead of |last_decoded| by more than 0x7fff.
// This is because |last_recieved| is represented on the wire as a delta,
// and only 15 bits are available for that delta.
ABSL_MUST_USE_RESULT
bool Set(uint16_t last_decoded,
uint16_t last_received,
bool decodability_flag);
bool decodability_flag) RTC_WARN_UNUSED_RESULT;
// RTP sequence number of the first packet belong to the last decoded
// non-discardable frame.