zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove TaskQueue::PostAndReply as unused

Browse Source 
Bug: webrtc:10191, webrtc:9728
Change-Id: Iaaa7c88bbbbfdd6e3e9bf5ab683bbdb2962a5cab
Reviewed-on: https://webrtc-review.googlesource.com/c/107202
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26202}
This commit is contained in:
Danil Chapovalov
2018-12-05 15:46:58 +01:00
committed by Commit Bot
parent a8f58f001e
commit 43f3982d6f
5 changed files with 9 additions and 356 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
rtc_base/task_queue.h
View File

@ -175,11 +175,6 @@ class RTC_LOCKABLE RTC_EXPORT TaskQueue {
// Ownership of the task is passed to PostTask.
void PostTask(std::unique_ptr<QueuedTask> task);
void PostTaskAndReply(std::unique_ptr<QueuedTask> task,
std::unique_ptr<QueuedTask> reply,
TaskQueue* reply_queue);
void PostTaskAndReply(std::unique_ptr<QueuedTask> task,
std::unique_ptr<QueuedTask> reply);
// Schedules a task to execute a specified number of milliseconds from when
// the call is made. The precision should be considered as "best effort"
@ -208,32 +203,15 @@ class RTC_LOCKABLE RTC_EXPORT TaskQueue {
PostDelayedTask(NewClosure(std::forward<Closure>(closure)), milliseconds);
}
template <class Closure1, class Closure2>
void PostTaskAndReply(Closure1&& task,
Closure2&& reply,
TaskQueue* reply_queue) {
PostTaskAndReply(NewClosure(std::forward<Closure1>(task)),
NewClosure(std::forward<Closure2>(reply)), reply_queue);
}
template <class Closure>
void PostTaskAndReply(std::unique_ptr<QueuedTask> task, Closure&& reply) {
PostTaskAndReply(std::move(task), NewClosure(std::forward<Closure>(reply)));
}
template <class Closure>
void PostTaskAndReply(Closure&& task, std::unique_ptr<QueuedTask> reply) {
PostTaskAndReply(NewClosure(std::forward<Closure>(task)), std::move(reply));
}
template <class Closure1, class Closure2>
void PostTaskAndReply(Closure1&& task, Closure2&& reply) {
PostTaskAndReply(NewClosure(std::forward(task)),
NewClosure(std::forward(reply)));
}
private:
class Impl;
// TODO(danilchap): Remove when external implementaions of TaskQueue remove
// these two functions.
void PostTaskAndReply(std::unique_ptr<QueuedTask> task,
std::unique_ptr<QueuedTask> reply,
TaskQueue* reply_queue);
void PostTaskAndReply(std::unique_ptr<QueuedTask> task,
std::unique_ptr<QueuedTask> reply);
const scoped_refptr<Impl> impl_;