zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove SdpAudioFormat's default constructor

Browse Source 
We didn't really want it; it was only necessary because we wanted to
use rtc::Optional<SdpAudioFormat>, and Optional used to require the
contained type to be default constructable. But as of May 9th
(https://codereview.webrtc.org/1896833004), it no longer does.

Review-Url: https://codereview.webrtc.org/2066233002
Cr-Commit-Position: refs/heads/master@{#13211}
This commit is contained in:
kwiberg
2016-06-20 02:39:48 -07:00
committed by Commit bot
parent a7d88d3844
commit 44bf02fba2
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/modules/audio_coding/codecs/audio_format.cc
View File

@ -12,7 +12,6 @@
namespace webrtc {
SdpAudioFormat::SdpAudioFormat() = default;
SdpAudioFormat::SdpAudioFormat(const SdpAudioFormat&) = default;
SdpAudioFormat::SdpAudioFormat(SdpAudioFormat&&) = default;

3
webrtc/modules/audio_coding/codecs/audio_format.h
View File

@ -23,9 +23,6 @@ namespace webrtc {
struct SdpAudioFormat {
using Parameters = std::map<std::string, std::string>;
// TODO(kwiberg): Get rid of the default constructor when rtc::Optional no
// longer requires it.
SdpAudioFormat();
SdpAudioFormat(const SdpAudioFormat&);
SdpAudioFormat(SdpAudioFormat&&);
SdpAudioFormat(const char* name, int clockrate_hz, int num_channels);