zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use size_t more consistently for packet/payload lengths.

Browse Source 
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pkasting@chromium.org
2014-11-20 22:28:14 +00:00
parent edc6e57a92
commit 4591fbd09f
341 changed files with 2610 additions and 2613 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/rtp_rtcp/interface/fec_receiver.h
View File

@ -24,7 +24,7 @@ class FecReceiver {
virtual int32_t AddReceivedRedPacket(const RTPHeader& rtp_header,
const uint8_t* incoming_rtp_packet,
int packet_length,
size_t packet_length,
uint8_t ulpfec_payload_type) = 0;
virtual int32_t ProcessReceivedFec() = 0;

2
webrtc/modules/rtp_rtcp/interface/receive_statistics.h
View File

@ -26,7 +26,7 @@ class StreamStatistician {
virtual ~StreamStatistician();
virtual bool GetStatistics(RtcpStatistics* statistics, bool reset) = 0;
virtual void GetDataCounters(uint32_t* bytes_received,
virtual void GetDataCounters(size_t* bytes_received,
uint32_t* packets_received) const = 0;
virtual uint32_t BitrateReceived() const = 0;

2
webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h
View File

@ -83,7 +83,7 @@ class RTPPayloadRegistry {
bool RestoreOriginalPacket(uint8_t** restored_packet,
const uint8_t* packet,
int* packet_length,
size_t* packet_length,
uint32_t original_ssrc,
const RTPHeader& header) const;

2
webrtc/modules/rtp_rtcp/interface/rtp_receiver.h
View File

@ -72,7 +72,7 @@ class RtpReceiver {
// detected and acted upon.
virtual bool IncomingRtpPacket(const RTPHeader& rtp_header,
const uint8_t* payload,
int payload_length,
size_t payload_length,
PayloadUnion payload_specific,
bool in_order) = 0;

8
webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h
View File

@ -83,7 +83,7 @@ class RtpRtcp : public Module {
***************************************************************************/
virtual int32_t IncomingRtcpPacket(const uint8_t* incoming_packet,
uint16_t incoming_packet_length) = 0;
size_t incoming_packet_length) = 0;
virtual void SetRemoteSSRC(const uint32_t ssrc) = 0;
@ -328,7 +328,7 @@ class RtpRtcp : public Module {
const uint32_t timeStamp,
int64_t capture_time_ms,
const uint8_t* payloadData,
const uint32_t payloadSize,
const size_t payloadSize,
const RTPFragmentationHeader* fragmentation = NULL,
const RTPVideoHeader* rtpVideoHdr = NULL) = 0;
@ -337,7 +337,7 @@ class RtpRtcp : public Module {
int64_t capture_time_ms,
bool retransmission) = 0;
virtual int TimeToSendPadding(int bytes) = 0;
virtual size_t TimeToSendPadding(size_t bytes) = 0;
virtual bool GetSendSideDelay(int* avg_send_delay_ms,
int* max_send_delay_ms) const = 0;
@ -465,7 +465,7 @@ class RtpRtcp : public Module {
* return -1 on failure else 0
*/
virtual int32_t DataCountersRTP(
uint32_t* bytesSent,
size_t* bytesSent,
uint32_t* packetsSent) const = 0;
/*
* Get received RTCP sender info

10
webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h
View File

@ -143,7 +143,7 @@ enum RtxMode {
// instead of padding.
};
const int kRtxHeaderSize = 2;
const size_t kRtxHeaderSize = 2;
struct RTCPSenderInfo
{
@ -220,11 +220,11 @@ public:
virtual int32_t OnReceivedPayloadData(
const uint8_t* payloadData,
const uint16_t payloadSize,
const size_t payloadSize,
const WebRtcRTPHeader* rtpHeader) = 0;
virtual bool OnRecoveredPacket(const uint8_t* packet,
int packet_length) = 0;
size_t packet_length) = 0;
};
class RtpFeedback
@ -334,13 +334,13 @@ class NullRtpData : public RtpData {
virtual int32_t OnReceivedPayloadData(
const uint8_t* payloadData,
const uint16_t payloadSize,
const size_t payloadSize,
const WebRtcRTPHeader* rtpHeader) OVERRIDE {
return 0;
}
virtual bool OnRecoveredPacket(const uint8_t* packet,
int packet_length) OVERRIDE {
size_t packet_length) OVERRIDE {
return true;
}
};