zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Assorted logging pedantry

Browse Source 
This cl fixes various minor issues found during a quick scan of the current log
usage.

Bug: webrtc:8529
Change-Id: I1e1eb02ef220177dbb327203509736ad7f70cc1c
Reviewed-on: https://webrtc-review.googlesource.com/52262
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21996}
This commit is contained in:
Jonas Olsson
2018-02-13 10:37:07 +01:00
committed by Commit Bot
parent a6cc0f94bf
commit 45cc890560
21 changed files with 67 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
media/base/rtpdataengine.cc
View File

@ -202,18 +202,11 @@ void RtpDataMediaChannel::OnPacketReceived(
rtc::CopyOnWriteBuffer* packet, const rtc::PacketTime& packet_time) {
RtpHeader header;
if (!GetRtpHeader(packet->cdata(), packet->size(), &header)) {
// Don't want to log for every corrupt packet.
// RTC_LOG(LS_WARNING) << "Could not read rtp header from packet of length "
// << packet->length() << ".";
return;
}
size_t header_length;
if (!GetRtpHeaderLen(packet->cdata(), packet->size(), &header_length)) {
// Don't want to log for every corrupt packet.
// RTC_LOG(LS_WARNING) << "Could not read rtp header"
// << length from packet of length "
// << packet->length() << ".";
return;
}
const char* data =
@ -227,12 +220,6 @@ void RtpDataMediaChannel::OnPacketReceived(
}
if (!FindCodecById(recv_codecs_, header.payload_type)) {
// For bundling, this will be logged for every message.
// So disable this logging.
// RTC_LOG(LS_WARNING) << "Not receiving packet "
// << header.ssrc << ":" << header.seq_num
// << " (" << data_len << ")"
// << " because unknown payload id: " << header.payload_type;
return;
}