zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Delete VideoCodec::plName"

Browse Source 
This reverts commit 89d88c0b9d61975bc63623ab8028377d8f9733dc.

Reason for revert: Breaks an internal project.

Original change's description:
> Delete VideoCodec::plName
> 
> All use was deleted in cl https://webrtc-review.googlesource.com/56100, now
> delete the actual member too.
> 
> Bug: webrtc:8830
> Change-Id: Iabbfd8eb08078e39a8e57f33f7c6a9de4bc3b6cb
> Reviewed-on: https://webrtc-review.googlesource.com/60300
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22353}

TBR=kwiberg@webrtc.org,nisse@webrtc.org

Change-Id: I4901d2a7ef6de5f87520d7026906608904cf825e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8830
Reviewed-on: https://webrtc-review.googlesource.com/60901
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22363}
This commit is contained in:
Niels Moller
2018-03-09 13:58:28 +00:00
committed by Commit Bot
parent 72467c24ac
commit 465e96291d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common_types.h
View File

@ -397,6 +397,8 @@ enum class VideoType {
};
// Video codec
// TODO(nisse): Delete together with VideoCodec::plName, below.
enum { kPayloadNameSize = 32 };
enum { kMaxSimulcastStreams = 4 };
enum { kMaxSpatialLayers = 5 };
enum { kMaxTemporalStreams = 4 };
@ -519,6 +521,9 @@ class VideoCodec {
// Public variables. TODO(hta): Make them private with accessors.
VideoCodecType codecType;
// TODO(nisse): Unused in webrtc, delete as soon as downstream
// applications are updated to not use it.
char plName[kPayloadNameSize];
unsigned char plType;
unsigned short width;