zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iwyu: MacOS Homebrew support

Browse Source 
Bug: None
Change-Id: I7eba64647715b6e109e88faa177e48056eb001de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280580
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38477}
This commit is contained in:
Florent Castelli
2022-10-26 14:00:17 +02:00
committed by WebRTC LUCI CQ
parent 35b3c63ba4
commit 48a0c1a860
1 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tools_webrtc/iwyu/apply-iwyu
View File

@ -1,4 +1,4 @@
#!/bin/sh #!/usr/bin/env bash
# #
# Run the include-what-you-use tool (iwyu) on a file in the webrtc source # Run the include-what-you-use tool (iwyu) on a file in the webrtc source
# directory. # directory.
@ -24,17 +24,30 @@ if [ $DEBUG -gt 0 ]; then
set -x set -x
fi fi
IWYU_TOOL="${IWYU_TOOL:-/usr/bin/iwyu_tool}"
FIX_INCLUDE="${FIX_INCLUDE:-/usr/bin/fix_include}"
FIX_INCLUDE_ARGS=''
IWYU_TOOL_DIR="${IWYU_TOOL_DIR:-tools_webrtc/iwyu}"
COMPILE_COMMANDS=''
error() { error() {
echo "$*" >&2 echo "$*" >&2
exit 1 exit 1
} }
find_alternates() {
for name in "$@"
do
name_path=$(which "${name}")
if [ ! -z "${name_path}" ]; then
echo ${name_path}
return 0
fi
done
error "Could not find any of the tools '$@' in PATH."
return 1
}
IWYU_TOOL=$(find_alternates iwyu_tool iwyu_tool.py)
FIX_INCLUDE=$(find_alternates fix_include fix_includes.py)
FIX_INCLUDE_ARGS=''
IWYU_TOOL_DIR="${IWYU_TOOL_DIR:-tools_webrtc/iwyu}"
COMPILE_COMMANDS=''
usage() { usage() {
echo "Usage: $0 [ -c compile-commands-file.json ] [-r] file.cc" echo "Usage: $0 [ -c compile-commands-file.json ] [-r] file.cc"
echo "Runs the IWYU and fix-include on a CC file and its associated .h file" echo "Runs the IWYU and fix-include on a CC file and its associated .h file"
@ -81,26 +94,27 @@ else
FILE_H="" FILE_H=""
fi fi
tmpfile=$(realpath $(mktemp iwyu.XXXXXXX))
trap 'rm -f -- "${tmpfile}"' EXIT
# IWYU has a confusing set of exit codes. Discard it. # IWYU has a confusing set of exit codes. Discard it.
"$IWYU_TOOL" -p "$COMPILE_COMMANDS" "$FILE_CC" -- -Xiwyu --no_fwd_decls \ "$IWYU_TOOL" -p "$COMPILE_COMMANDS" "$FILE_CC" -- -Xiwyu --no_fwd_decls \
-Xiwyu --mapping_file=../../$IWYU_TOOL_DIR/mappings.imp \ -Xiwyu --mapping_file=../../$IWYU_TOOL_DIR/mappings.imp \
>& /tmp/includefixes$$ || echo "IWYU done, code $?" >& ${tmpfile} || echo "IWYU done, code $?"
if grep 'fatal error' /tmp/includefixes$$; then if grep 'fatal error' ${tmpfile}; then
echo "iwyu run failed" echo "iwyu run failed"
cat /tmp/includefixes$$ cat ${tmpfile}
rm /tmp/includefixes$$
exit 1 exit 1
else else
if [ $DEBUG -gt 1 ]; then if [ $DEBUG -gt 1 ]; then
cat /tmp/includefixes$$ cat ${tmpfile}
fi fi
# In compile_commands.json, the file name is recorded # In compile_commands.json, the file name is recorded
# as a relative path to the build directory. # as a relative path to the build directory.
pushd "$(dirname "$COMPILE_COMMANDS")" || error "pushd failed" pushd "$(dirname "$COMPILE_COMMANDS")" || error "pushd failed"
"$FIX_INCLUDE" $FIX_INCLUDE_ARGS < /tmp/includefixes$$ || echo "Some files modified" "$FIX_INCLUDE" $FIX_INCLUDE_ARGS < ${tmpfile} || echo "Some files modified"
popd popd
rm /tmp/includefixes$$
fi fi
grep -v -f tools_webrtc/iwyu/iwyu-filter-list $FILE_CC > $FILE_CC.new grep -v -f tools_webrtc/iwyu/iwyu-filter-list $FILE_CC > $FILE_CC.new