Refactor/reimplement RTC event log triage alerts.
- Moves AnalyzerConfig and helper functions IsAudioSsrc, IsVideoSsrc, IsRtxSsrc, GetStreamNam and GetLayerName to analyzer_common.h - Moves log_segments() code to rtc_event_log_parser.h - Moves TriageAlert/Notification code to a new file with a couple of minor fixes to make it less spammy. Bug: webrtc:11566 Change-Id: Ib33941d8185f7382fc72ed65768e46015e0320de Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174824 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31318}
This commit is contained in:
committed by
Commit Bot
parent
41559a2b46
commit
48b8279813
83
rtc_tools/rtc_event_log_visualizer/analyzer_common.cc
Normal file
83
rtc_tools/rtc_event_log_visualizer/analyzer_common.cc
Normal file
@ -0,0 +1,83 @@
|
||||
|
||||
/*
|
||||
* Copyright (c) 2020 The WebRTC project authors. All Rights Reserved.
|
||||
*
|
||||
* Use of this source code is governed by a BSD-style license
|
||||
* that can be found in the LICENSE file in the root of the source
|
||||
* tree. An additional intellectual property rights grant can be found
|
||||
* in the file PATENTS. All contributing project authors may
|
||||
* be found in the AUTHORS file in the root of the source tree.
|
||||
*/
|
||||
|
||||
#include "rtc_tools/rtc_event_log_visualizer/analyzer_common.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
bool IsRtxSsrc(const ParsedRtcEventLog& parsed_log,
|
||||
PacketDirection direction,
|
||||
uint32_t ssrc) {
|
||||
if (direction == kIncomingPacket) {
|
||||
return parsed_log.incoming_rtx_ssrcs().find(ssrc) !=
|
||||
parsed_log.incoming_rtx_ssrcs().end();
|
||||
} else {
|
||||
return parsed_log.outgoing_rtx_ssrcs().find(ssrc) !=
|
||||
parsed_log.outgoing_rtx_ssrcs().end();
|
||||
}
|
||||
}
|
||||
|
||||
bool IsVideoSsrc(const ParsedRtcEventLog& parsed_log,
|
||||
PacketDirection direction,
|
||||
uint32_t ssrc) {
|
||||
if (direction == kIncomingPacket) {
|
||||
return parsed_log.incoming_video_ssrcs().find(ssrc) !=
|
||||
parsed_log.incoming_video_ssrcs().end();
|
||||
} else {
|
||||
return parsed_log.outgoing_video_ssrcs().find(ssrc) !=
|
||||
parsed_log.outgoing_video_ssrcs().end();
|
||||
}
|
||||
}
|
||||
|
||||
bool IsAudioSsrc(const ParsedRtcEventLog& parsed_log,
|
||||
PacketDirection direction,
|
||||
uint32_t ssrc) {
|
||||
if (direction == kIncomingPacket) {
|
||||
return parsed_log.incoming_audio_ssrcs().find(ssrc) !=
|
||||
parsed_log.incoming_audio_ssrcs().end();
|
||||
} else {
|
||||
return parsed_log.outgoing_audio_ssrcs().find(ssrc) !=
|
||||
parsed_log.outgoing_audio_ssrcs().end();
|
||||
}
|
||||
}
|
||||
|
||||
std::string GetStreamName(const ParsedRtcEventLog& parsed_log,
|
||||
PacketDirection direction,
|
||||
uint32_t ssrc) {
|
||||
char buffer[200];
|
||||
rtc::SimpleStringBuilder name(buffer);
|
||||
if (IsAudioSsrc(parsed_log, direction, ssrc)) {
|
||||
name << "Audio ";
|
||||
} else if (IsVideoSsrc(parsed_log, direction, ssrc)) {
|
||||
name << "Video ";
|
||||
} else {
|
||||
name << "Unknown ";
|
||||
}
|
||||
if (IsRtxSsrc(parsed_log, direction, ssrc)) {
|
||||
name << "RTX ";
|
||||
}
|
||||
if (direction == kIncomingPacket)
|
||||
name << "(In) ";
|
||||
else
|
||||
name << "(Out) ";
|
||||
name << "SSRC " << ssrc;
|
||||
return name.str();
|
||||
}
|
||||
|
||||
std::string GetLayerName(LayerDescription layer) {
|
||||
char buffer[100];
|
||||
rtc::SimpleStringBuilder name(buffer);
|
||||
name << "SSRC " << layer.ssrc << " sl " << layer.spatial_layer << ", tl "
|
||||
<< layer.temporal_layer;
|
||||
return name.str();
|
||||
}
|
||||
|
||||
} // namespace webrtc
|
||||
Reference in New Issue
Block a user