zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove AudioProcessing::UpdateHistogramsOnCallEnd.

Browse Source 
Bug: webrtc:10198
Change-Id: I3e7a98f9b94c171e7f105883fc755e44b2e991ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173464
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31070}
This commit is contained in:
Mirko Bonadei
2020-04-12 18:00:52 +02:00
committed by Commit Bot
parent f0684b5a8a
commit 491ff3d54c
4 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_processing/audio_processing_impl.cc
View File

@ -1913,8 +1913,6 @@ void AudioProcessingImpl::InitializePreProcessor() {
}
}
void AudioProcessingImpl::UpdateHistogramsOnCallEnd() {}
void AudioProcessingImpl::WriteAecDumpConfigMessage(bool forced) {
if (!aec_dump_) {
return;

1
modules/audio_processing/audio_processing_impl.h
View File

@ -69,7 +69,6 @@ class AudioProcessingImpl : public AudioProcessing {
int Initialize(const ProcessingConfig& processing_config) override;
void ApplyConfig(const AudioProcessing::Config& config) override;
void SetExtraOptions(const webrtc::Config& config) override;
void UpdateHistogramsOnCallEnd() override;
void AttachAecDump(std::unique_ptr<AecDump> aec_dump) override;
void DetachAecDump() override;
void AttachPlayoutAudioGenerator(

6
modules/audio_processing/include/audio_processing.h
View File

@ -624,12 +624,6 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface {
// attached, its destructor is called.
virtual void DetachPlayoutAudioGenerator() = 0;
// Use to send UMA histograms at end of a call. Note that all histogram
// specific member variables are reset.
// Deprecated. This method is deprecated and will be removed.
// TODO(peah): Remove this method.
virtual void UpdateHistogramsOnCallEnd() = 0;
// Get audio processing statistics.
virtual AudioProcessingStats GetStatistics() = 0;
// TODO(webrtc:5298) Deprecated variant. The |has_remote_tracks| argument

1
modules/audio_processing/include/mock_audio_processing.h
View File

@ -136,7 +136,6 @@ class MockAudioProcessing : public ::testing::NiceMock<AudioProcessing> {
std::unique_ptr<AudioGenerator> audio_generator) {}
MOCK_METHOD0(DetachPlayoutAudioGenerator, void());
MOCK_METHOD0(UpdateHistogramsOnCallEnd, void());
MOCK_METHOD0(GetStatistics, AudioProcessingStats());
MOCK_METHOD1(GetStatistics, AudioProcessingStats(bool));