zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NetEqImpl::GetDecoderFormat: Return RTP clockrate, not codec sample rate

Browse Source 
Well, in fact we need to return both. But return codec sample rate
separately and let the SdpAudioFormat contain the RTP clockrate,
otherwise we're essentially lying to our callers.

Bug: webrtc:11028
Change-Id: I40f36cb9db6b9824404ade6b0515a8312ff97009
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156307
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29444}
This commit is contained in:
Karl Wiberg
2019-10-11 09:37:42 +02:00
committed by Commit Bot
parent 3b819f3d8b
commit 4b64411406
6 changed files with 42 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_coding/neteq/neteq_impl.h
View File

@ -182,7 +182,7 @@ class NetEqImpl : public webrtc::NetEq {
int last_output_sample_rate_hz() const override;
absl::optional<SdpAudioFormat> GetDecoderFormat(
absl::optional<DecoderFormat> GetDecoderFormat(
int payload_type) const override;
// Flushes both the packet buffer and the sync buffer.