zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "dcsctp: Use rtc::CopyOnWriteBuffer"

Browse Source 
This reverts commit 2db59a6584eca54245794a0e657ca9ded9e6707f.

Reason for revert: Causes msan-issue in crc32c, reading uninitialized
memory.

Bug: webrtc:12943, chromium:1275559
Change-Id: I05f1012d896aeaca86c4562e0df15fa7ea326d60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239560
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35461}
This commit is contained in:
Victor Boivie
2021-12-01 18:57:22 +00:00
committed by WebRTC LUCI CQ
parent 4ad09762da
commit 4b7024b572
19 changed files with 86 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
net/dcsctp/testing/data_generator.cc
View File

@ -34,8 +34,8 @@ Data DataGenerator::Ordered(std::vector<uint8_t> payload,
}
MID message_id = opts.message_id.value_or(message_id_);
Data ret = Data(opts.stream_id, SSN(static_cast<uint16_t>(*message_id)),
message_id, fsn_, opts.ppid, rtc::CopyOnWriteBuffer(payload),
is_beginning, is_end, IsUnordered(false));
message_id, fsn_, opts.ppid, std::move(payload), is_beginning,
is_end, IsUnordered(false));
if (is_end) {
message_id_ = MID(*message_id + 1);
@ -56,8 +56,7 @@ Data DataGenerator::Unordered(std::vector<uint8_t> payload,
}
MID message_id = opts.message_id.value_or(message_id_);
Data ret = Data(opts.stream_id, SSN(0), message_id, fsn_, kPpid,
rtc::CopyOnWriteBuffer(payload), is_beginning, is_end,
IsUnordered(true));
std::move(payload), is_beginning, is_end, IsUnordered(true));
if (is_end) {
message_id_ = MID(*message_id + 1);
}