zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Split out RtcpCnameCallback from RtcpStatisticsCallback

Browse Source 
Cname callback is used only on receive side, and statistics (soon)
only on the send side.

Bug: webrtc:10679
Change-Id: I122e9cafaea93cd0ba75dc955a652d9d4bddc379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147867
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28767}
This commit is contained in:
Niels Möller
2019-08-05 12:45:19 +02:00
committed by Commit Bot
parent ed44f5464a
commit 4d7c405599
15 changed files with 47 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
View File

@ -84,7 +84,11 @@ class MockRtcpLossNotificationObserver : public RtcpLossNotificationObserver {
class MockRtcpCallbackImpl : public RtcpStatisticsCallback {
public:
MOCK_METHOD2(StatisticsUpdated, void(const RtcpStatistics&, uint32_t));
MOCK_METHOD2(CNameChanged, void(const char*, uint32_t));
};
class MockCnameCallbackImpl : public RtcpCnameCallback {
public:
MOCK_METHOD2(OnCname, void(uint32_t, absl::string_view));
};
class MockReportBlockDataObserverImpl : public ReportBlockDataObserver {
@ -584,12 +588,12 @@ TEST_F(RtcpReceiverTest, InjectApp) {
TEST_F(RtcpReceiverTest, InjectSdesWithOneChunk) {
const char kCname[] = "alice@host";
MockRtcpCallbackImpl callback;
rtcp_receiver_.RegisterRtcpStatisticsCallback(&callback);
MockCnameCallbackImpl callback;
rtcp_receiver_.RegisterRtcpCnameCallback(&callback);
rtcp::Sdes sdes;
sdes.AddCName(kSenderSsrc, kCname);
EXPECT_CALL(callback, CNameChanged(StrEq(kCname), kSenderSsrc));
EXPECT_CALL(callback, OnCname(kSenderSsrc, StrEq(kCname)));
InjectRtcpPacket(sdes);
char cName[RTCP_CNAME_SIZE];