zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some leftover TODOs for webrtc:10336

Browse Source 
Some of the TODOs associated with webrtc:10336 which are
currently in the codebase have recently been resolved,
but not all relevant TODOs have been removed.

TBR=kwiberg@webrtc.org

Bug: webrtc:10336
Change-Id: Iff1d0fc94dee5bf49226f6ea3d9127fea77e9d68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139902
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28167}
This commit is contained in:
Elad Alon
2019-06-03 22:28:10 +02:00
committed by Commit Bot
parent aa3e6129f9
commit 4d9e428286
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/include/module_common_types.h
View File

@ -93,7 +93,6 @@ class KeyFrameRequestSender {
};
// Interface used by LossNotificationController to communicate to RtpRtcp.
// TODO(bugs.webrtc.org/10336): Hook up to RtpRtcp.
class LossNotificationSender {
public:
virtual ~LossNotificationSender() {}

3
video/rtp_video_stream_receiver.cc
View File

@ -336,9 +336,6 @@ int32_t RtpVideoStreamReceiver::OnReceivedPayloadData(
RTC_LOG(LS_WARNING)
<< "LossNotificationController does not support reordering.";
} else {
// TODO(bugs.webrtc.org/10336): Coordinate with |nack_module_| to make
// sure that only a single RTCP packet is produced if both a LNTF as
// well as a NACK (or key frame request) should be issued.
loss_notification_controller_->OnReceivedPacket(packet);
}
}