zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

compare Optional<unsigned> only to unsigned integers

Browse Source 
more standard optional<T> inlines compares instead of converting second argument to T.
that leads to warnings about comparing unsigned to signed integers.

Bug: webrtc:9078
Change-Id: I43cc729d3b85d789b0c394064dc7e11dc27a37aa
Reviewed-on: https://webrtc-review.googlesource.com/66782
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22779}
This commit is contained in:
Danil Chapovalov
2018-04-06 18:03:46 +02:00
committed by Commit Bot
parent 96a0e60c6b
commit 4da18e89bd
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rtc_base/string_to_number_unittest.cc
View File

@ -42,15 +42,16 @@ TYPED_TEST_P(BasicNumberTest, TestValidNumbers) {
using T = TypeParam;
constexpr T min_value = std::numeric_limits<T>::lowest();
constexpr T max_value = std::numeric_limits<T>::max();
constexpr T zero_value = 0;
const std::string min_string = std::to_string(min_value);
const std::string max_string = std::to_string(max_value);
EXPECT_EQ(min_value, StringToNumber<T>(min_string));
EXPECT_EQ(min_value, StringToNumber<T>(min_string.c_str()));
EXPECT_EQ(max_value, StringToNumber<T>(max_string));
EXPECT_EQ(max_value, StringToNumber<T>(max_string.c_str()));
EXPECT_EQ(0, StringToNumber<T>("0"));
EXPECT_EQ(0, StringToNumber<T>("-0"));
EXPECT_EQ(0, StringToNumber<T>(std::string("-0000000000000")));
EXPECT_EQ(zero_value, StringToNumber<T>("0"));
EXPECT_EQ(zero_value, StringToNumber<T>("-0"));
EXPECT_EQ(zero_value, StringToNumber<T>(std::string("-0000000000000")));
}
TYPED_TEST_P(BasicNumberTest, TestInvalidNumbers) {