zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Remove some default implementations in api/rtp_transcever_interface"

Browse Source 
This reverts commit 226a2e32d03df3a2cf4bf3c616ac00dcd91ed3d2.

Reason for revert: Downstream fixed (will submit when true)

Original change's description:
> Revert "Remove some default implementations in api/rtp_transcever_interface"
>
> This reverts commit 40941ee72d30676296f3545004e7a6e30b959612.
>
> Reason for revert: breaks downstream project
>
> Original change's description:
> > Remove some default implementations in api/rtp_transcever_interface
> >
> > Bug: webrtc:11839
> > Change-Id: I6ddc0468e75bc346e12fc3dc64236ca2ab52e708
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244504
> > Reviewed-by: Henrik Boström <hbos@webrtc.org>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#35701}
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:11839
> Change-Id: I8a3eb0a279b28ed8b55745af97596c4a853669be
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247186
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Owners-Override: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35713}

# Not skipping CQ checks because this is a reland.

Bug: webrtc:11839
Change-Id: Ie25f1a5fdb4ef8ebf200780755a69dc09dd28ccb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247189
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35737}
This commit is contained in:
Harald Alvestrand
2022-01-17 21:20:49 +00:00
committed by WebRTC LUCI CQ
parent 4b5caee6b1
commit 4f19950660
3 changed files with 10 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
api/rtp_transceiver_interface.cc
View File

@ -44,33 +44,6 @@ void RtpTransceiverInterface::StopInternal() {
<< "DEBUG: RtpTransceiverInterface::StopInternal called";
}
RTCError RtpTransceiverInterface::SetCodecPreferences(
rtc::ArrayView<RtpCodecCapability>) {
RTC_DCHECK_NOTREACHED() << "Not implemented";
return {};
}
std::vector<RtpCodecCapability> RtpTransceiverInterface::codec_preferences()
const {
return {};
}
std::vector<RtpHeaderExtensionCapability>
RtpTransceiverInterface::HeaderExtensionsToOffer() const {
return {};
}
webrtc::RTCError RtpTransceiverInterface::SetOfferedRtpHeaderExtensions(
rtc::ArrayView<const RtpHeaderExtensionCapability>
header_extensions_to_offer) {
return webrtc::RTCError(webrtc::RTCErrorType::UNSUPPORTED_OPERATION);
}
std::vector<RtpHeaderExtensionCapability>
RtpTransceiverInterface::HeaderExtensionsNegotiated() const {
return {};
}
// TODO(bugs.webrtc.org/11839) Remove default implementations when clients
// are updated.
void RtpTransceiverInterface::SetDirection(