zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Renamed new EncodeInternal to EncodeImpl to ensure proper backwards compatibility.

Browse Source 
Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.

Review URL: https://codereview.webrtc.org/1764583003

Cr-Commit-Position: refs/heads/master@{#11868}
This commit is contained in:
ossu
2016-03-04 00:54:32 -08:00
committed by Commit bot
parent 88950cfbf9
commit 4f43fcfd49
23 changed files with 62 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc
View File

@ -1648,7 +1648,7 @@ TEST_F(AcmSenderBitExactnessOldApi, External_Pcmu_20ms) {
EXPECT_CALL(mock_encoder, GetTargetBitrate())
.Times(AtLeast(1))
.WillRepeatedly(Invoke(&encoder, &AudioEncoderPcmU::GetTargetBitrate));
EXPECT_CALL(mock_encoder, EncodeInternal(_, _, _))
EXPECT_CALL(mock_encoder, EncodeImpl(_, _, _))
.Times(AtLeast(1))
.WillRepeatedly(Invoke(&encoder,
static_cast<

4
webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc
View File

@ -122,14 +122,14 @@ TEST(RentACodecTest, ExternalEncoder) {
::testing::InSequence s;
info.encoded_timestamp = 0;
EXPECT_CALL(external_encoder,
EncodeInternal(0, rtc::ArrayView<const int16_t>(audio),
EncodeImpl(0, rtc::ArrayView<const int16_t>(audio),
&encoded))
.WillOnce(Return(info));
EXPECT_CALL(external_encoder, Mark("A"));
EXPECT_CALL(external_encoder, Mark("B"));
info.encoded_timestamp = 2;
EXPECT_CALL(external_encoder,
EncodeInternal(2, rtc::ArrayView<const int16_t>(audio),
EncodeImpl(2, rtc::ArrayView<const int16_t>(audio),
&encoded))
.WillOnce(Return(info));
EXPECT_CALL(external_encoder, Die());