zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Battery]: TaskQueuePacedSender not started by default.

Browse Source 
Following up on https://webrtc-review.googlesource.com/c/src/+/213000
This CL prevents scheduling work before TaskQueuePacedSender::EnsureStarted(),
making it necessary to function.

Bug: chromium:1152887
Change-Id: I848c9e6d6057a404626ad693b1f4dc7fba797a9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214320
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#33695}
This commit is contained in:
Etienne Pierre-doray
2021-04-07 20:03:53 +00:00
committed by Commit Bot
parent 9ff75a6206
commit 5051693ada
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/pacing/task_queue_paced_sender.h
View File

@ -154,9 +154,7 @@ class TaskQueuePacedSender : public RtpPacketPacer, public RtpPacketSender {
// Indicates if this task queue is started. If not, don't allow
// posting delayed tasks yet.
// TODO(crbug.com/1152887): Initialize to false once all users call
// EnsureStarted().
bool is_started_ RTC_GUARDED_BY(task_queue_) = true;
bool is_started_ RTC_GUARDED_BY(task_queue_) = false;
// Indicates if this task queue is shutting down. If so, don't allow
// posting any more delayed tasks as that can cause the task queue to

3
modules/pacing/task_queue_paced_sender_unittest.cc
View File

@ -562,8 +562,7 @@ namespace test {
kProbingRate * TimeDelta::Millis(1) + DataSize::Bytes(1));
}
// TODO(crbug.com/1152887): Enable once pacer no longer auto-starts.
TEST(TaskQueuePacedSenderTest, DISABLED_NoStatsUpdatesBeforeStart) {
TEST(TaskQueuePacedSenderTest, NoStatsUpdatesBeforeStart) {
const TimeDelta kCoalescingWindow = TimeDelta::Millis(5);
GlobalSimulatedTimeController time_controller(Timestamp::Millis(1234));
MockPacketRouter packet_router;