zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some WebRtcVideoEngine2 unittest stubs.

Browse Source 
Also contains some cleanup/typo fixes.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/55449004

Cr-Commit-Position: refs/heads/master@{#9277}
This commit is contained in:
Peter Boström
2015-05-25 15:04:24 +02:00
parent d8399e630f
commit 54be3e0049
1 changed files with 4 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
talk/media/webrtc/webrtcvideoengine2_unittest.cc
View File

@ -1132,11 +1132,11 @@ TEST_F(WebRtcVideoChannel2Test, IdenticalRecvExtensionsDoesntRecreateStream) {
kRtpVideoRotationHeaderExtension, kVideoRotationId)); kRtpVideoRotationHeaderExtension, kVideoRotationId));
EXPECT_TRUE(channel_->SetRecvRtpHeaderExtensions(extensions)); EXPECT_TRUE(channel_->SetRecvRtpHeaderExtensions(extensions));
FakeVideoReceiveStream* send_stream = FakeVideoReceiveStream* recv_stream =
AddRecvStream(cricket::StreamParams::CreateLegacy(123)); AddRecvStream(cricket::StreamParams::CreateLegacy(123));
EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams()); EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
ASSERT_EQ(3u, send_stream->GetConfig().rtp.extensions.size()); ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
// Setting the same extensions (even if in different order) shouldn't // Setting the same extensions (even if in different order) shouldn't
// reallocate the stream. // reallocate the stream.
@ -2890,16 +2890,6 @@ TEST_F(WebRtcVideoEngine2SimulcastTest, DISABLED_TestAdaptToOutputFormat) {
FAIL() << "Not implemented."; FAIL() << "Not implemented.";
} }
TEST_F(WebRtcVideoEngine2SimulcastTest, DISABLED_TestAdaptToCpuLoad) {
// TODO(pbos): Implement.
FAIL() << "Not implemented.";
}
TEST_F(WebRtcVideoEngine2SimulcastTest, DISABLED_TestAdaptToCpuLoadDisabled) {
// TODO(pbos): Implement.
FAIL() << "Not implemented.";
}
TEST_F(WebRtcVideoEngine2SimulcastTest, TEST_F(WebRtcVideoEngine2SimulcastTest,
DISABLED_TestAdaptWithCpuOveruseObserver) { DISABLED_TestAdaptWithCpuOveruseObserver) {
// TODO(pbos): Implement. // TODO(pbos): Implement.
@ -2920,7 +2910,7 @@ TEST_F(WebRtcVideoEngine2SimulcastTest,
} }
TEST_F(WebRtcVideoEngine2SimulcastTest, TEST_F(WebRtcVideoEngine2SimulcastTest,
DISABLED_DontUseSimulcastAdapterOnNoneVp8Factory) { DISABLED_DontUseSimulcastAdapterOnNonVp8Factory) {
// TODO(pbos): Implement. // TODO(pbos): Implement.
FAIL() << "Not implemented."; FAIL() << "Not implemented.";
} }
@ -2960,8 +2950,7 @@ TEST_F(WebRtcVideoChannel2SimulcastTest, DISABLED_SimulcastSend_480x300) {
FAIL() << "Not implemented."; FAIL() << "Not implemented.";
} }
TEST_F(WebRtcVideoChannel2SimulcastTest, TEST_F(WebRtcVideoChannel2SimulcastTest, DISABLED_SimulcastSend_480x270) {
DISABLED_DISABLED_SimulcastSend_480x270) {
// TODO(pbos): Implement. // TODO(pbos): Implement.
FAIL() << "Not implemented."; FAIL() << "Not implemented.";
} }
@ -2976,14 +2965,6 @@ TEST_F(WebRtcVideoChannel2SimulcastTest, DISABLED_SimulcastSend_320x180) {
FAIL() << "Not implemented."; FAIL() << "Not implemented.";
} }
// Test reset send codec with simulcast.
// Disabled per b/6773425
TEST_F(WebRtcVideoChannel2SimulcastTest,
DISABLED_DISABLED_SimulcastResetSendCodec) {
// TODO(pbos): Implement.
FAIL() << "Not implemented.";
}
// Test simulcast streams are decodeable with expected sizes. // Test simulcast streams are decodeable with expected sizes.
TEST_F(WebRtcVideoChannel2SimulcastTest, DISABLED_SimulcastStreams) { TEST_F(WebRtcVideoChannel2SimulcastTest, DISABLED_SimulcastStreams) {
// TODO(pbos): Implement. // TODO(pbos): Implement.