zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove clang:find_bad_constructs suppression from logging (part 1).

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I443c0c77cef30a3f5712f72ce88db80d1fb29874
Reviewed-on: https://webrtc-review.googlesource.com/96642
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24567}
This commit is contained in:
Mirko Bonadei
2018-09-03 09:47:38 +02:00
committed by Commit Bot
parent b267b0e021
commit 55d5ef0048
11 changed files with 94 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
logging/rtc_event_log/rtc_event_log_parser.cc
View File

@ -236,6 +236,13 @@ void GetHeaderExtensions(std::vector<RtpExtension>* header_extensions,
} // namespace
ParsedRtcEventLog::ParsedRtcEventLog() = default;
ParsedRtcEventLog::~ParsedRtcEventLog() = default;
ParsedRtcEventLog::BweProbeResultEvent::BweProbeResultEvent() = default;
ParsedRtcEventLog::BweProbeResultEvent::BweProbeResultEvent(
const BweProbeResultEvent&) = default;
bool ParsedRtcEventLog::ParseFile(const std::string& filename) {
std::ifstream file(filename, std::ios_base::in | std::ios_base::binary);
if (!file.good() || !file.is_open()) {